Title: [254563] trunk/Tools
- Revision
- 254563
- Author
- ab...@igalia.com
- Date
- 2020-01-15 03:45:50 -0800 (Wed, 15 Jan 2020)
Log Message
[WTF] Remove MediaTime.cpp test warning in GCC
https://bugs.webkit.org/show_bug.cgi?id=206238
Reviewed by Xabier Rodriguez-Calvar.
GCC emits warnings when it finds clang pragmas, so I'm wrapping them
in #if COMPILER(CLANG) to reduce the noise.
* TestWebKitAPI/Tests/WTF/MediaTime.cpp:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (254562 => 254563)
--- trunk/Tools/ChangeLog 2020-01-15 11:30:52 UTC (rev 254562)
+++ trunk/Tools/ChangeLog 2020-01-15 11:45:50 UTC (rev 254563)
@@ -1,3 +1,15 @@
+2020-01-15 Alicia Boya García <ab...@igalia.com>
+
+ [WTF] Remove MediaTime.cpp test warning in GCC
+ https://bugs.webkit.org/show_bug.cgi?id=206238
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ GCC emits warnings when it finds clang pragmas, so I'm wrapping them
+ in #if COMPILER(CLANG) to reduce the noise.
+
+ * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
+
2020-01-14 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r254480, r254496, and r254517.
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp (254562 => 254563)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp 2020-01-15 11:30:52 UTC (rev 254562)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp 2020-01-15 11:45:50 UTC (rev 254563)
@@ -58,10 +58,14 @@
// MediaTime values should be able to be declared static anywhere, just like you can do so with integers.
// This should not require global constructors or destructors.
+#if COMPILER(CLANG)
#pragma clang diagnostic push
#pragma clang diagnostic error "-Wglobal-constructors"
+#endif
static const MediaTime oneSecond(1, 1);
+#if COMPILER(CLANG)
#pragma clang diagnostic pop
+#endif
TEST(WTF, MediaTime)
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
