Title: [255364] trunk/Source/WebCore
- Revision
- 255364
- Author
- andresg...@apple.com
- Date
- 2020-01-29 10:01:14 -0800 (Wed, 29 Jan 2020)
Log Message
Crash in AXIsolatedObject destruction.
https://bugs.webkit.org/show_bug.cgi?id=206828
Reviewed by Carlos Alberto Lopez Perez.
Fix for crash on GTK introduced with this IsolatedTree change.
* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::detachPlatformWrapper):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (255363 => 255364)
--- trunk/Source/WebCore/ChangeLog 2020-01-29 17:39:49 UTC (rev 255363)
+++ trunk/Source/WebCore/ChangeLog 2020-01-29 18:01:14 UTC (rev 255364)
@@ -1,3 +1,15 @@
+2020-01-29 Andres Gonzalez <andresg...@apple.com>
+
+ Crash in AXIsolatedObject destruction.
+ https://bugs.webkit.org/show_bug.cgi?id=206828
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ Fix for crash on GTK introduced with this IsolatedTree change.
+
+ * accessibility/atk/AccessibilityObjectAtk.cpp:
+ (WebCore::AccessibilityObject::detachPlatformWrapper):
+
2020-01-29 Peng Liu <peng.l...@apple.com>
Always enable some log messages related to audio tracks
Modified: trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp (255363 => 255364)
--- trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp 2020-01-29 17:39:49 UTC (rev 255363)
+++ trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp 2020-01-29 18:01:14 UTC (rev 255364)
@@ -37,8 +37,14 @@
void AccessibilityObject::detachPlatformWrapper(AccessibilityDetachmentType detachmentType)
{
- if (auto* cache = axObjectCache())
- cache->detachWrapper(this, detachmentType);
+ if (detachmentType != AccessibilityDetachmentType::CacheDestroyed) {
+ if (auto* cache = axObjectCache())
+ cache->detachWrapper(this, detachmentType);
+ }
+
+ auto* wrapper = this->wrapper();
+ ASSERT(wrapper);
+ webkitAccessibleDetach(WEBKIT_ACCESSIBLE(wrapper));
}
bool AccessibilityObject::accessibilityIgnoreAttachment() const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
