Title: [255484] trunk/Source/WebCore
Revision
255484
Author
rn...@webkit.org
Date
2020-01-30 21:28:11 -0800 (Thu, 30 Jan 2020)

Log Message

Crash in GraphicsLayerCA::fetchCloneLayers() when setting contents to solid color
https://bugs.webkit.org/show_bug.cgi?id=205530

Patch by Doug Kelly <do...@apple.com> on 2020-01-30
Reviewed by Ryosuke Niwa.

Change the assertion in fetchCloneLayers() to check for null explicitly to ensure contentsLayer is valid.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (255483 => 255484)


--- trunk/Source/WebCore/ChangeLog	2020-01-31 04:21:39 UTC (rev 255483)
+++ trunk/Source/WebCore/ChangeLog	2020-01-31 05:28:11 UTC (rev 255484)
@@ -1,3 +1,15 @@
+2020-01-30  Doug Kelly  <do...@apple.com>
+
+        Crash in GraphicsLayerCA::fetchCloneLayers() when setting contents to solid color
+        https://bugs.webkit.org/show_bug.cgi?id=205530
+
+        Reviewed by Ryosuke Niwa.
+
+        Change the assertion in fetchCloneLayers() to check for null explicitly to ensure contentsLayer is valid.
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
+
 2020-01-30  Fujii Hironori  <hironori.fu...@sony.com>
 
         [Cairo] Use CAIRO_FILTER_BILINEAR for image tile painting with InterpolationQuality::Default

Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (255483 => 255484)


--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2020-01-31 04:21:39 UTC (rev 255483)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2020-01-31 05:28:11 UTC (rev 255484)
@@ -4035,8 +4035,7 @@
         replicaState.setBranchType(ReplicaState::ChildBranch);
     }
 
-    if (contentsClippingLayer) {
-        ASSERT(contentsLayer);
+    if (contentsClippingLayer && contentsLayer) {
         contentsClippingLayer->appendSublayer(*contentsLayer);
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to