Title: [255886] trunk/Source/WebInspectorUI
- Revision
- 255886
- Author
- nvasil...@apple.com
- Date
- 2020-02-05 18:16:43 -0800 (Wed, 05 Feb 2020)
Log Message
Web Inspector: Bezier editor popover should be strictly LTR
https://bugs.webkit.org/show_bug.cgi?id=206968
<rdar://problem/59007065>
Reviewed by Timothy Hatcher.
- Don't mirror the coordinate system.
- Don't reverste the order of the cubic bezier values, e.g. `cubic-bezier(0, 0.5, 1, 0.5)`.
* UserInterface/Views/BezierEditor.css:
(90%):
(to):
(body[dir=ltr] .bezier-editor): Deleted.
(body[dir=rtl] .bezier-editor): Deleted.
(body[dir=rtl] .bezier-editor > .bezier-container): Deleted.
* UserInterface/Views/BezierEditor.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (255885 => 255886)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-02-06 02:13:47 UTC (rev 255885)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-02-06 02:16:43 UTC (rev 255886)
@@ -1,3 +1,22 @@
+2020-02-05 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Bezier editor popover should be strictly LTR
+ https://bugs.webkit.org/show_bug.cgi?id=206968
+ <rdar://problem/59007065>
+
+ Reviewed by Timothy Hatcher.
+
+ - Don't mirror the coordinate system.
+ - Don't reverste the order of the cubic bezier values, e.g. `cubic-bezier(0, 0.5, 1, 0.5)`.
+
+ * UserInterface/Views/BezierEditor.css:
+ (90%):
+ (to):
+ (body[dir=ltr] .bezier-editor): Deleted.
+ (body[dir=rtl] .bezier-editor): Deleted.
+ (body[dir=rtl] .bezier-editor > .bezier-container): Deleted.
+ * UserInterface/Views/BezierEditor.js:
+
2020-02-03 Carlos Garcia Campos <cgar...@igalia.com>
Unreviewed. Fix the inspector files combination after r255547
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css (255885 => 255886)
--- trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css 2020-02-06 02:13:47 UTC (rev 255885)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css 2020-02-06 02:16:43 UTC (rev 255886)
@@ -30,14 +30,6 @@
--bezier-editor-preview-translateX: 170px;
}
-body[dir=ltr] .bezier-editor {
- --bezier-editor-preview-translateX-animate: var(--bezier-editor-preview-translateX);
-}
-
-body[dir=rtl] .bezier-editor {
- --bezier-editor-preview-translateX-animate: calc(-1 * var(--bezier-editor-preview-translateX));
-}
-
.bezier-editor > .bezier-preview {
width: calc(100% - 10px);
height: 25px;
@@ -69,8 +61,8 @@
@keyframes bezierPreview {
from { transform: translateX(0); }
10% { transform: translateX(0); }
- 90% { transform: translateX(var(--bezier-editor-preview-translateX-animate)); }
- to { transform: translateX(var(--bezier-editor-preview-translateX-animate)); }
+ 90% { transform: translateX(var(--bezier-editor-preview-translateX)); }
+ to { transform: translateX(var(--bezier-editor-preview-translateX)); }
}
.bezier-editor > .bezier-container {
@@ -77,10 +69,6 @@
margin: 0 8px;
}
-body[dir=rtl] .bezier-editor > .bezier-container {
- transform: scaleX(-1);
-}
-
.bezier-editor > .bezier-container .linear-curve {
fill: none;
stroke: var(--text-color-quaternary);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js (255885 => 255886)
--- trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js 2020-02-06 02:13:47 UTC (rev 255885)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js 2020-02-06 02:16:43 UTC (rev 255886)
@@ -31,6 +31,7 @@
this._element = document.createElement("div");
this._element.classList.add("bezier-editor");
+ this._element.dir = "ltr";
var editorWidth = 184;
var editorHeight = 200;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
