Title: [255896] trunk/Source/WebInspectorUI
Revision
255896
Author
nvasil...@apple.com
Date
2020-02-05 19:36:04 -0800 (Wed, 05 Feb 2020)

Log Message

Web Inspector: Some cookie table column headers should not be localizable
https://bugs.webkit.org/show_bug.cgi?id=206920

Reviewed by Timothy Hatcher.

Keep headers that match cookie directives always in English.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/CookieStorageContentView.js:
(WI.CookieStorageContentView.prototype.initialLayout):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (255895 => 255896)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-02-06 03:28:43 UTC (rev 255895)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-02-06 03:36:04 UTC (rev 255896)
@@ -1,3 +1,16 @@
+2020-02-05  Nikita Vasilyev  <nvasil...@apple.com>
+
+        Web Inspector: Some cookie table column headers should not be localizable
+        https://bugs.webkit.org/show_bug.cgi?id=206920
+
+        Reviewed by Timothy Hatcher.
+
+        Keep headers that match cookie directives always in English.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/CookieStorageContentView.js:
+        (WI.CookieStorageContentView.prototype.initialLayout):
+
 2020-02-05  Devin Rousso  <drou...@apple.com>
 
         Web Inspector: slightly increase the horizontal padding around scope bar items

Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (255895 => 255896)


--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2020-02-06 03:28:43 UTC (rev 255895)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2020-02-06 03:36:04 UTC (rev 255896)
@@ -533,7 +533,6 @@
 localizedStrings["Expand columns"] = "Expand columns";
 localizedStrings["Expanded"] = "Expanded";
 localizedStrings["Experimental"] = "Experimental";
-localizedStrings["Expires"] = "Expires";
 localizedStrings["Export"] = "Export";
 localizedStrings["Export (%s)"] = "Export (%s)";
 localizedStrings["Export HAR"] = "Export HAR";

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js (255895 => 255896)


--- trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js	2020-02-06 03:28:43 UTC (rev 255895)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js	2020-02-06 03:36:04 UTC (rev 255896)
@@ -180,19 +180,19 @@
             hideable: false,
         });
 
-        this._domainColumn = new WI.TableColumn("domain", WI.UIString("Domain"), {
+        this._domainColumn = new WI.TableColumn("domain", WI.unlocalizedString("Domain"), {
             minWidth: 100,
             maxWidth: 200,
             initialWidth: 120,
         });
 
-        this._pathColumn = new WI.TableColumn("path", WI.UIString("Path"), {
+        this._pathColumn = new WI.TableColumn("path", WI.unlocalizedString("Path"), {
             minWidth: 50,
             maxWidth: 300,
             initialWidth: 100,
         });
 
-        this._expiresColumn = new WI.TableColumn("expires", WI.UIString("Expires"), {
+        this._expiresColumn = new WI.TableColumn("expires", WI.unlocalizedString("Expires"), {
             minWidth: 100,
             maxWidth: 200,
             initialWidth: 150,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to