Title: [256418] trunk/Source/WebCore
Revision
256418
Author
bfulg...@apple.com
Date
2020-02-11 17:21:09 -0800 (Tue, 11 Feb 2020)

Log Message

REGRESSION (r236025): Correct flaky WebGL2 test failures
https://bugs.webkit.org/show_bug.cgi?id=207595
<rdar://problem/59367393>

Reviewed by Jon Lee.

Correct handling of sample parameters in the prototype WebGL2 implementation.

Tested by existing tests.

* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getInternalformatParameter):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (256417 => 256418)


--- trunk/Source/WebCore/ChangeLog	2020-02-12 01:08:08 UTC (rev 256417)
+++ trunk/Source/WebCore/ChangeLog	2020-02-12 01:21:09 UTC (rev 256418)
@@ -1,3 +1,18 @@
+2020-02-11  Brent Fulgham  <bfulg...@apple.com>
+
+        REGRESSION (r236025): Correct flaky WebGL2 test failures
+        https://bugs.webkit.org/show_bug.cgi?id=207595
+        <rdar://problem/59367393>
+
+        Reviewed by Jon Lee.
+
+        Correct handling of sample parameters in the prototype WebGL2 implementation.
+
+        Tested by existing tests.
+
+        * html/canvas/WebGL2RenderingContext.cpp:
+        (WebCore::WebGL2RenderingContext::getInternalformatParameter):
+
 2020-02-11  Zalan Bujtas  <za...@apple.com>
 
         [LFC] Rename Layout::Container to Layout::ContainerBox

Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp (256417 => 256418)


--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp	2020-02-12 01:08:08 UTC (rev 256417)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp	2020-02-12 01:21:09 UTC (rev 256418)
@@ -423,7 +423,7 @@
     // the value of GL_NUM_SAMPLE_COUNTS will be zero for such formats.
     numValues = isIntegerFormat(internalformat) ? 0 : samples.size();
     GCGLint params[numValues];
-    for (size_t i = 0; i < samples.size(); ++i)
+    for (size_t i = 0; i < static_cast<size_t>(numValues); ++i)
         params[i] = samples[i];
 #endif
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to