Title: [256916] trunk/LayoutTests
Revision
256916
Author
commit-qu...@webkit.org
Date
2020-02-19 02:37:31 -0800 (Wed, 19 Feb 2020)

Log Message

Main implementation for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=200764

Patch by Rob Buis <rb...@igalia.com> on 2020-02-19
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

When updating WPT tests in a lost minute change I forgot to add webkit-test-runner headers.
Remaining failures are tracked in https://bugs.webkit.org/show_bug.cgi?id=207902 and
https://bugs.webkit.org/show_bug.cgi?id=207901.

* web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html:
* web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub.html:
* web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2.html:
* web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-iframe.html:
* web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied.html:
* web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub.html:
* web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub.html:

LayoutTests:

Update test expectations to skip
image-loading-lazy-in-cross-origin-ifame-001.sub.html and
image-loading-lazy-in-cross-origin-ifame-002.sub.html.

* platform/mac-wk1/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (256915 => 256916)


--- trunk/LayoutTests/ChangeLog	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/ChangeLog	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,3 +1,17 @@
+2020-02-19  Rob Buis  <rb...@igalia.com>
+
+        Main implementation for lazy image loading
+        https://bugs.webkit.org/show_bug.cgi?id=200764
+
+        Reviewed by Frédéric Wang.
+
+        Update test expectations to skip
+        image-loading-lazy-in-cross-origin-ifame-001.sub.html and
+        image-loading-lazy-in-cross-origin-ifame-002.sub.html.
+
+        * platform/mac-wk1/TestExpectations:
+        * platform/win/TestExpectations:
+
 2020-02-19  Alejandro G. Castro  <a...@igalia.com>
 
         REGRESSION(r188639): Several inspector tests timeout because they are slow after r188639

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,3 +1,28 @@
+2020-02-19  Rob Buis  <rb...@igalia.com>
+
+        Main implementation for lazy image loading
+        https://bugs.webkit.org/show_bug.cgi?id=200764
+
+        Reviewed by Frédéric Wang.
+
+        When updating WPT tests in a lost minute change I forgot to add webkit-test-runner headers.
+        Remaining failures are tracked in https://bugs.webkit.org/show_bug.cgi?id=207902 and
+        https://bugs.webkit.org/show_bug.cgi?id=207901.
+
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub-expected.txt:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub-expected.txt:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub.html:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2-expected.txt:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2.html:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-expected.txt:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-iframe.html:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied.html:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub-expected.txt:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub.html:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub-expected.txt:
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub.html:
+
 2020-02-17  Chris Dumez  <cdu...@apple.com>
 
         Defer execution of async scripts until until the document is loaded

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub-expected.txt (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub-expected.txt	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub-expected.txt	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,7 +1,5 @@
 
 
-Harness Error (TIMEOUT), message = null
+PASS An image with loading='lazy' in cross origin iframe loads when it gets
+       visible by scrolling the iframe's scroll port 
 
-TIMEOUT An image with loading='lazy' in cross origin iframe loads when it gets
-       visible by scrolling the iframe's scroll port Test timed out
-

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
 <head>
 <title>An image with loading='lazy' in cross origin iframe loads when it gets
        visible by scrolling the iframe's scroll port</title>

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub-expected.txt (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub-expected.txt	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub-expected.txt	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,7 +1,5 @@
 
 
-Harness Error (TIMEOUT), message = null
+PASS An image with loading='lazy' in cross origin iframe loads when it gets
+       visible by scrolling the parent scroll container of the iframe 
 
-TIMEOUT An image with loading='lazy' in cross origin iframe loads when it gets
-       visible by scrolling the parent scroll container of the iframe Test timed out
-

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub.html (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub.html	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub.html	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
 <head>
 <title>An image with loading='lazy' in cross origin iframe loads when it gets
        visible by scrolling the parent scroll container of the iframe</title>

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2-expected.txt (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2-expected.txt	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2-expected.txt	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,4 +1,4 @@
 
 
-FAIL Deferred images with loading='lazy' use the original base URL specified at the parse time assert_true: Below-viewport loading=lazy images do not block the window load event expected true got false
+FAIL Deferred images with loading='lazy' use the original base URL specified at the parse time assert_unreached: The image request should not load relative to the current (incorrect) base URL. Reached unreachable code
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2.html (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2.html	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2.html	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
 <head>
   <title>Deferred images with loading='lazy' use the original
          base URL specified at the parse time</title>

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-expected.txt (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-expected.txt	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-expected.txt	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,5 +1,5 @@
   
 
 PASS Test that when deferred iframe is loaded, it uses the base URL computed at parse time. 
-PASS Test that when deferred img is loaded, it uses the base URL computed at parse time. 
+FAIL Test that when deferred img is loaded, it uses the base URL computed at parse time. assert_unreached: The image load should not fail, trying to load with invalid base URL. Reached unreachable code
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-iframe.html (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-iframe.html	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-iframe.html	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
 <head>
   <title>Deferred iframes with loading='lazy' use the original
          base URL specified at the parse time</title>

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied.html (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied.html	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied.html	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
 <head>
   <title>Deferred iframes and images with loading='lazy' use the original base URL specified at the parse time</title>
   <link rel="author" title="Raj T" href=""

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub-expected.txt (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub-expected.txt	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub-expected.txt	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,5 +1,4 @@
 Blocked access to external URL http://www.127.0.0.1:8800/html/semantics/embedded-content/the-img-element/resources/image.png
-Blocked access to external URL http://www.127.0.0.1:8800/html/semantics/embedded-content/the-img-element/resources/image.png
 
 
 FAIL Test that when deferred image is loaded, it uses the crossorigin attribute specified at parse time. assert_unreached: The image load should not fail, trying to load with CORS headers set. Reached unreachable code

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub.html (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub.html	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub.html	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
 <head>
   <title>Deferred images with loading='lazy' use the original crossorigin attribute specified at the parse time</title>
   <link rel="author" title="Raj T" href=""

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub-expected.txt (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub-expected.txt	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub-expected.txt	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,5 +1,5 @@
   
 
 PASS Test that when deferred iframe is loaded, it uses the referrer-policy specified at parse time. 
-PASS Test that when deferred img is loaded, it uses the referrer-policy specified at parse time. 
+FAIL Test that when deferred img is loaded, it uses the referrer-policy specified at parse time. assert_unreached: The image load should not fail, by sending the wrong referer header. Reached unreachable code
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub.html (256915 => 256916)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub.html	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub.html	2020-02-19 10:37:31 UTC (rev 256916)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
 <head>
   <title>Deferred iframes and images with loading='lazy' use the original referrer-policy specified at the parse time</title>
   <link rel="author" title="Raj T" href=""

Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256915 => 256916)


--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-19 10:37:31 UTC (rev 256916)
@@ -163,6 +163,8 @@
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html [ Skip ]

Modified: trunk/LayoutTests/platform/win/TestExpectations (256915 => 256916)


--- trunk/LayoutTests/platform/win/TestExpectations	2020-02-19 10:32:49 UTC (rev 256915)
+++ trunk/LayoutTests/platform/win/TestExpectations	2020-02-19 10:37:31 UTC (rev 256916)
@@ -4540,6 +4540,8 @@
 http/tests/lazyload [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html [ Skip ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to