Title: [103800] trunk
- Revision
- 103800
- Author
- commit-qu...@webkit.org
- Date
- 2011-12-29 07:08:57 -0800 (Thu, 29 Dec 2011)
Log Message
Unreviewed, rolling out r103798.
http://trac.webkit.org/changeset/103798
https://bugs.webkit.org/show_bug.cgi?id=75353
some small scrollbar differences are making the tests fail on
several platforms (Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review....@gmail.com> on 2011-12-29
Source/WebCore:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
LayoutTests:
* fast/layers/scroll-with-transform-composited-layer-expected.html: Removed.
* fast/layers/scroll-with-transform-composited-layer.html: Removed.
* fast/layers/scroll-with-transform-layer-expected.html: Removed.
* fast/layers/scroll-with-transform-layer.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (103799 => 103800)
--- trunk/LayoutTests/ChangeLog 2011-12-29 14:58:11 UTC (rev 103799)
+++ trunk/LayoutTests/ChangeLog 2011-12-29 15:08:57 UTC (rev 103800)
@@ -1,3 +1,17 @@
+2011-12-29 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r103798.
+ http://trac.webkit.org/changeset/103798
+ https://bugs.webkit.org/show_bug.cgi?id=75353
+
+ some small scrollbar differences are making the tests fail on
+ several platforms (Requested by jchaffraix on #webkit).
+
+ * fast/layers/scroll-with-transform-composited-layer-expected.html: Removed.
+ * fast/layers/scroll-with-transform-composited-layer.html: Removed.
+ * fast/layers/scroll-with-transform-layer-expected.html: Removed.
+ * fast/layers/scroll-with-transform-layer.html: Removed.
+
2011-12-29 Julien Chaffraix <jchaffr...@webkit.org>
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
Deleted: trunk/LayoutTests/fast/layers/scroll-with-transform-composited-layer-expected.html (103799 => 103800)
--- trunk/LayoutTests/fast/layers/scroll-with-transform-composited-layer-expected.html 2011-12-29 14:58:11 UTC (rev 103799)
+++ trunk/LayoutTests/fast/layers/scroll-with-transform-composited-layer-expected.html 2011-12-29 15:08:57 UTC (rev 103800)
@@ -1,50 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<style>
- p { height: 300px; width: 100px; margin: 0px; }
- p.green { background-color: green; }
- div { height: 100px; width: 100px; }
- div.relative { position: relative }
- div.composited
- {
- -webkit-transform: translateZ(0);
- -moz-transform: translateZ(0);
- transform: translateZ(0);
- }
-</style>
-</head>
-<body>
- <span>http://webkit.org/b/67100: REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling</span>
- <span>All the boxes should only contain green content.</span>
- <div class="scrollMe composited" style="overflow: hidden;">
- <div class="relative">
- <p class="green"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe composited" style="overflow: scroll;">
- <div class="relative">
- <p class="green"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe composited" style="overflow: hidden;">
- <div class="relative">
- <p class="green"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe composited" style="overflow: scroll;">
- <div class="relative">
- <p class="green"></p>
- </div>
- </div>
- <br>
- <script>
- var scrollMes = document.getElementsByClassName("scrollMe");
- for (var i = 0; i < scrollMes.length; ++i)
- scrollMes[i].scrollTop = 100;
- </script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/layers/scroll-with-transform-composited-layer.html (103799 => 103800)
--- trunk/LayoutTests/fast/layers/scroll-with-transform-composited-layer.html 2011-12-29 14:58:11 UTC (rev 103799)
+++ trunk/LayoutTests/fast/layers/scroll-with-transform-composited-layer.html 2011-12-29 15:08:57 UTC (rev 103800)
@@ -1,67 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<style>
- p { height: 100px; width: 100px; margin: 0px; }
- p.red { background-color: red; }
- p.green { background-color: green; }
- div { height: 100px; width: 100px; }
- div.relative { position: relative }
- div.composited
- {
- -webkit-transform: translateZ(0);
- -moz-transform: translateZ(0);
- transform: translateZ(0);
- }
- div.translated
- {
- -webkit-transform: translate(0);
- -moz-transform: translate(0);
- transform: translate(0);
- }
-</style>
-</head>
-<body>
- <span>http://webkit.org/b/67100: REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling</span>
- <span>All the boxes should only contain green content.</span>
- <!-- Use a translation. -->
- <div class="scrollMe composited" style="overflow: hidden;">
- <div class="relative">
- <p class="red"></p>
- <p class="green"></p>
- <p class="red"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe composited" style="overflow: scroll;">
- <div class="relative">
- <p class="red"></p>
- <p class="green"></p>
- <p class="red"></p>
- </div>
- </div>
- <br>
- <!-- Nest composited and non-composited. -->
- <div class="scrollMe composited" style="overflow: hidden;">
- <div class="relative translated">
- <p class="red"></p>
- <p class="green"></p>
- <p class="red"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe translated" style="overflow: scroll;">
- <div class="relative composited">
- <p class="red"></p>
- <p class="green"></p>
- <p class="red"></p>
- </div>
- </div>
- <br>
- <script>
- var scrollMes = document.getElementsByClassName("scrollMe");
- for (var i = 0; i < scrollMes.length; ++i)
- scrollMes[i].scrollTop = 100;
- </script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/layers/scroll-with-transform-layer-expected.html (103799 => 103800)
--- trunk/LayoutTests/fast/layers/scroll-with-transform-layer-expected.html 2011-12-29 14:58:11 UTC (rev 103799)
+++ trunk/LayoutTests/fast/layers/scroll-with-transform-layer-expected.html 2011-12-29 15:08:57 UTC (rev 103800)
@@ -1,44 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<style>
- p { height: 300px; width: 100px; margin: 0px; }
- p.green { background-color: green; }
- div { height: 100px; width: 100px; }
- div.relative { position: relative }
-</style>
-</head>
-<body>
- <span>http://webkit.org/b/67100: REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling</span>
- <span>All the boxes should only contain green content.</span>
- <div class="scrollMe" style="overflow: hidden;">
- <div class="relative">
- <p class="green"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe" style="overflow: scroll;">
- <div class="relative">
- <p class="green"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe" style="overflow: hidden;">
- <div class="relative">
- <p class="green"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe" style="overflow: scroll;">
- <div class="relative">
- <p class="green"></p>
- </div>
- </div>
- <br>
- <script>
- var scrollMes = document.getElementsByClassName("scrollMe");
- for (var i = 0; i < scrollMes.length; ++i)
- scrollMes[i].scrollTop = 100;
- </script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/layers/scroll-with-transform-layer.html (103799 => 103800)
--- trunk/LayoutTests/fast/layers/scroll-with-transform-layer.html 2011-12-29 14:58:11 UTC (rev 103799)
+++ trunk/LayoutTests/fast/layers/scroll-with-transform-layer.html 2011-12-29 15:08:57 UTC (rev 103800)
@@ -1,67 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<style>
- p { height: 100px; width: 100px; margin: 0px; }
- p.red { background-color: red; }
- p.green { background-color: green; }
- div { height: 100px; width: 100px; }
- div.relative { position: relative }
- div.rotated
- {
- -webkit-transform: rotate(360deg);
- -moz-transform: rotate(360deg);
- transform: rotate(360deg);
- }
- div.translated
- {
- -webkit-transform: translate(0);
- -moz-transform: translate(0);
- transform: translate(0);
- }
-</style>
-</head>
-<body>
- <span>http://webkit.org/b/67100: REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling</span>
- <span>All the boxes should only contain green content.</span>
- <!-- Use a translation. -->
- <div class="scrollMe translated" style="overflow: hidden;">
- <div class="relative">
- <p class="red"></p>
- <p class="green"></p>
- <p class="red"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe translated" style="overflow: scroll;">
- <div class="relative">
- <p class="red"></p>
- <p class="green"></p>
- <p class="red"></p>
- </div>
- </div>
- <br>
- <!-- Use a rotation. -->
- <div class="scrollMe rotated" style="overflow: hidden;">
- <div class="relative">
- <p class="red"></p>
- <p class="green"></p>
- <p class="red"></p>
- </div>
- </div>
- <br>
- <div class="scrollMe rotated" style="overflow: scroll;">
- <div class="relative">
- <p class="red"></p>
- <p class="green"></p>
- <p class="red"></p>
- </div>
- </div>
- <br>
- <script>
- var scrollMes = document.getElementsByClassName("scrollMe");
- for (var i = 0; i < scrollMes.length; ++i)
- scrollMes[i].scrollTop = 100;
- </script>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (103799 => 103800)
--- trunk/Source/WebCore/ChangeLog 2011-12-29 14:58:11 UTC (rev 103799)
+++ trunk/Source/WebCore/ChangeLog 2011-12-29 15:08:57 UTC (rev 103800)
@@ -1,3 +1,15 @@
+2011-12-29 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r103798.
+ http://trac.webkit.org/changeset/103798
+ https://bugs.webkit.org/show_bug.cgi?id=75353
+
+ some small scrollbar differences are making the tests fail on
+ several platforms (Requested by jchaffraix on #webkit).
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPositionsAfterScroll):
+
2011-12-29 Alexander Pavlov <apav...@chromium.org>
Web Inspector: Focus of the DOM tree is not restored when switching to the Elements panel
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (103799 => 103800)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-12-29 14:58:11 UTC (rev 103799)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-12-29 15:08:57 UTC (rev 103800)
@@ -465,6 +465,11 @@
// FIXME: Is it worth passing the offsetFromRoot around like in updateLayerPositions?
computeRepaintRects();
flags |= HasSeenFixedPositionedAncestor;
+ } else if (renderer()->hasTransform() && !renderer()->isRenderView()) {
+ // Transforms act as fixed position containers, so nothing inside a
+ // transformed element can be fixed relative to the viewport if the
+ // transformed element is not fixed itself or child of a fixed element.
+ return;
} else if ((flags & HasSeenAncestorWithOverflowClip) && !m_canSkipRepaintRectsUpdateOnScroll) {
// If we have seen an overflow clip, we should update our repaint rects as clippedOverflowRectForRepaint
// intersects it with our ancestor overflow clip that may have moved.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
