Title: [256941] trunk
Revision
256941
Author
keith_mil...@apple.com
Date
2020-02-19 13:23:23 -0800 (Wed, 19 Feb 2020)

Log Message

Disable Wasm reference types by default
https://bugs.webkit.org/show_bug.cgi?id=207952

Reviewed by Mark Lam.

JSTests:

* wasm/stress/immutable-globals.js:
* wasm/stress/local-ref.js:
* wasm/stress/mutable-globals.js:

Source/_javascript_Core:

* runtime/OptionsList.h:

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (256940 => 256941)


--- trunk/JSTests/ChangeLog	2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/JSTests/ChangeLog	2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,14 @@
+2020-02-19  Keith Miller  <keith_mil...@apple.com>
+
+        Disable Wasm reference types by default
+        https://bugs.webkit.org/show_bug.cgi?id=207952
+
+        Reviewed by Mark Lam.
+
+        * wasm/stress/immutable-globals.js:
+        * wasm/stress/local-ref.js:
+        * wasm/stress/mutable-globals.js:
+
 2020-02-18  Ross Kirsling  <ross.kirsl...@sony.com>
 
         [JSC] Computed function properties compute their keys twice

Modified: trunk/JSTests/wasm/stress/immutable-globals.js (256940 => 256941)


--- trunk/JSTests/wasm/stress/immutable-globals.js	2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/JSTests/wasm/stress/immutable-globals.js	2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,4 @@
+//@ requireOptions("--useWebAssemblyReferences=1")
 import Builder from '../Builder.js'
 import * as assert from '../assert.js'
 

Modified: trunk/JSTests/wasm/stress/local-ref.js (256940 => 256941)


--- trunk/JSTests/wasm/stress/local-ref.js	2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/JSTests/wasm/stress/local-ref.js	2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,4 @@
+//@ requireOptions("--useWebAssemblyReferences=1")
 import { instantiate } from "../wabt-wrapper.js";
 
 instantiate(`

Modified: trunk/JSTests/wasm/stress/mutable-globals.js (256940 => 256941)


--- trunk/JSTests/wasm/stress/mutable-globals.js	2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/JSTests/wasm/stress/mutable-globals.js	2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,4 @@
+//@ requireOptions("--useWebAssemblyReferences=1")
 import Builder from '../Builder.js'
 import * as assert from '../assert.js'
 

Modified: trunk/Source/_javascript_Core/ChangeLog (256940 => 256941)


--- trunk/Source/_javascript_Core/ChangeLog	2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,12 @@
+2020-02-19  Keith Miller  <keith_mil...@apple.com>
+
+        Disable Wasm reference types by default
+        https://bugs.webkit.org/show_bug.cgi?id=207952
+
+        Reviewed by Mark Lam.
+
+        * runtime/OptionsList.h:
+
 2020-02-19  Stephan Szabo  <stephan.sz...@sony.com>
 
         [PlayStation] Get jsc test wrappers using find_package

Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (256940 => 256941)


--- trunk/Source/_javascript_Core/runtime/OptionsList.h	2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h	2020-02-19 21:23:23 UTC (rev 256941)
@@ -478,7 +478,7 @@
     v(Size, webAssemblyBBQAirModeThreshold, isIOS() ? (10 * MB) : 0, Normal, "If 0, we always use BBQ Air. If Wasm module code size hits this threshold, we compile Wasm module with B3 BBQ mode.") \
     v(Bool, useWebAssemblyStreamingApi, enableWebAssemblyStreamingApi, Normal, "Allow to run WebAssembly's Streaming API") \
     v(Bool, useEagerWebAssemblyModuleHashing, false, Normal, "Unnamed WebAssembly modules are identified in backtraces through their hash, if available.") \
-    v(Bool, useWebAssemblyReferences, true, Normal, "Allow types from the wasm references spec.") \
+    v(Bool, useWebAssemblyReferences, false, Normal, "Allow types from the wasm references spec.") \
     v(Bool, useWebAssemblyMultiValues, true, Normal, "Allow types from the wasm mulit-values spec.") \
     v(Bool, useWeakRefs, false, Normal, "Expose the WeakRef constructor.") \
     v(Bool, useBigInt, false, Normal, "If true, we will enable BigInt support.") \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to