Title: [256949] trunk/Source/WebCore
- Revision
- 256949
- Author
- you...@apple.com
- Date
- 2020-02-19 14:10:22 -0800 (Wed, 19 Feb 2020)
Log Message
[mac debug] Regression: http/tests/websocket/tests/hybi/workers/worker-reload.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=207940
<rdar://problem/59592000>
Reviewed by Chris Dumez.
Covered by debug asserts.
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
Pass registrable domain instead of URL.
Isolate copy the domain before hopping to main thread for extra protection.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (256948 => 256949)
--- trunk/Source/WebCore/ChangeLog 2020-02-19 22:02:10 UTC (rev 256948)
+++ trunk/Source/WebCore/ChangeLog 2020-02-19 22:10:22 UTC (rev 256949)
@@ -1,5 +1,20 @@
2020-02-19 Youenn Fablet <you...@apple.com>
+ [mac debug] Regression: http/tests/websocket/tests/hybi/workers/worker-reload.html is a flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=207940
+ <rdar://problem/59592000>
+
+ Reviewed by Chris Dumez.
+
+ Covered by debug asserts.
+
+ * Modules/websockets/WebSocket.cpp:
+ (WebCore::WebSocket::connect):
+ Pass registrable domain instead of URL.
+ Isolate copy the domain before hopping to main thread for extra protection.
+
+2020-02-19 Youenn Fablet <you...@apple.com>
+
Remove PlatformMediaSession::characteristics()
https://bugs.webkit.org/show_bug.cgi?id=207926
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (256948 => 256949)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2020-02-19 22:02:10 UTC (rev 256948)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2020-02-19 22:10:22 UTC (rev 256949)
@@ -324,9 +324,9 @@
}
#if ENABLE(RESOURCE_LOAD_STATISTICS)
- auto reportRegistrableDomain = [url = "" context) {
+ auto reportRegistrableDomain = [domain = RegistrableDomain(m_url).isolatedCopy()](auto& context) mutable {
if (auto* frame = downcast<Document>(context).frame())
- frame->loader().client().addLoadedRegistrableDomain(RegistrableDomain(url));
+ frame->loader().client().addLoadedRegistrableDomain(WTFMove(domain));
};
if (is<Document>(context))
reportRegistrableDomain(context);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
