Title: [257032] branches/safari-609-branch/Source/WebKit
Revision
257032
Author
alanc...@apple.com
Date
2020-02-19 18:59:58 -0800 (Wed, 19 Feb 2020)

Log Message

Cherry-pick r257013. rdar://problem/59614282

    Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
    https://bugs.webkit.org/show_bug.cgi?id=207973

    Reviewed by Chris Dumez.

    Use RefPtr to store Frame*.

    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (257031 => 257032)


--- branches/safari-609-branch/Source/WebKit/ChangeLog	2020-02-20 02:59:53 UTC (rev 257031)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog	2020-02-20 02:59:58 UTC (rev 257032)
@@ -1,5 +1,34 @@
 2020-02-19  Russell Epstein  <repst...@apple.com>
 
+        Cherry-pick r257013. rdar://problem/59614282
+
+    Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
+    https://bugs.webkit.org/show_bug.cgi?id=207973
+    
+    Reviewed by Chris Dumez.
+    
+    Use RefPtr to store Frame*.
+    
+    * UIProcess/WebPageProxy.cpp:
+    (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-02-19  Ryosuke Niwa  <rn...@webkit.org>
+
+            Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
+            https://bugs.webkit.org/show_bug.cgi?id=207973
+
+            Reviewed by Chris Dumez.
+
+            Use RefPtr to store Frame*.
+
+            * UIProcess/WebPageProxy.cpp:
+            (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+
+2020-02-19  Russell Epstein  <repst...@apple.com>
+
         Cherry-pick r256859. rdar://problem/59576018
 
     [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded

Modified: branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (257031 => 257032)


--- branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-20 02:59:53 UTC (rev 257031)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-20 02:59:58 UTC (rev 257032)
@@ -4227,7 +4227,7 @@
 {
     PageClientProtector protector(pageClient());
 
-    WebFrameProxy* frame = process->webFrame(frameID);
+    auto frame = makeRefPtr(process->webFrame(frameID));
     MESSAGE_CHECK(process, frame);
     MESSAGE_CHECK_URL(process, url);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to