Title: [257042] trunk/Source/WebKit
- Revision
- 257042
- Author
- bb...@apple.com
- Date
- 2020-02-19 22:11:32 -0800 (Wed, 19 Feb 2020)
Log Message
Web Automation: Automation.setWindowFrameOfBrowsingContext should accept negative x and y-origin values
https://bugs.webkit.org/show_bug.cgi?id=207974
<rdar://problem/59606705>
Reviewed by Darin Adler.
According to the spec, negative origin values are supported:
https://w3c.github.io/webdriver/#set-window-rect
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (257041 => 257042)
--- trunk/Source/WebKit/ChangeLog 2020-02-20 06:08:12 UTC (rev 257041)
+++ trunk/Source/WebKit/ChangeLog 2020-02-20 06:11:32 UTC (rev 257042)
@@ -1,3 +1,18 @@
+2020-02-19 Brian Burg <bb...@apple.com>
+
+ Web Automation: Automation.setWindowFrameOfBrowsingContext should accept negative x and y-origin values
+ https://bugs.webkit.org/show_bug.cgi?id=207974
+ <rdar://problem/59606705>
+
+ Reviewed by Darin Adler.
+
+ According to the spec, negative origin values are supported:
+
+ https://w3c.github.io/webdriver/#set-window-rect
+
+ * UIProcess/Automation/WebAutomationSession.cpp:
+ (WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
+
2020-02-19 Chris Dumez <cdu...@apple.com>
Resources larger than 10MB are not stored in the disk cache
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (257041 => 257042)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2020-02-20 06:08:12 UTC (rev 257041)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2020-02-20 06:11:32 UTC (rev 257042)
@@ -389,12 +389,6 @@
if (!(y = optionalOriginObject->getNumber<float>("y"_s)))
ASYNC_FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(MissingParameter, "The 'y' parameter was not found or invalid.");
-
- if (x.value() < 0)
- ASYNC_FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(InvalidParameter, "The 'x' parameter had an invalid value.");
-
- if (y.value() < 0)
- ASYNC_FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(InvalidParameter, "The 'y' parameter had an invalid value.");
}
Optional<float> width;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
