Title: [257836] trunk
Revision
257836
Author
carlo...@webkit.org
Date
2020-03-04 00:54:57 -0800 (Wed, 04 Mar 2020)

Log Message

[GTK][WPE] Stop adding volume-box class to volume box element
https://bugs.webkit.org/show_bug.cgi?id=208510

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The class was removed in r257705 because it's not used by our css.

* Modules/mediacontrols/mediaControlsAdwaita.js:
(Controller.prototype.createControls):

LayoutTests:

Update expectations of http/tests/media/hls/video-controls-live-stream.html.

* platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (257835 => 257836)


--- trunk/LayoutTests/ChangeLog	2020-03-04 06:31:10 UTC (rev 257835)
+++ trunk/LayoutTests/ChangeLog	2020-03-04 08:54:57 UTC (rev 257836)
@@ -1,3 +1,14 @@
+2020-03-04  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK][WPE] Stop adding volume-box class to volume box element
+        https://bugs.webkit.org/show_bug.cgi?id=208510
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Update expectations of http/tests/media/hls/video-controls-live-stream.html.
+
+        * platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt:
+
 2020-03-03  Ryosuke Niwa  <rn...@webkit.org>
 
         REGRESSION(iOS): editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html is always timing out

Modified: trunk/LayoutTests/platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt (257835 => 257836)


--- trunk/LayoutTests/platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt	2020-03-04 06:31:10 UTC (rev 257835)
+++ trunk/LayoutTests/platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt	2020-03-04 08:54:57 UTC (rev 257836)
@@ -7,10 +7,10 @@
 -webkit-media-controls-panel: classes: [paused show]
 -webkit-media-controls-play-button: classes: [paused]
 -webkit-media-controls-timeline: classes: []
--webkit-media-controls-current-time-display: classes: [no-duration hour-long-time]
+-webkit-media-controls-current-time-display: classes: []
 none: classes: [mute-box]
 -webkit-media-controls-mute-button: classes: []
--webkit-media-controls-volume-slider-container: classes: [volume-box hiding]
+-webkit-media-controls-volume-slider-container: classes: [hiding]
 -webkit-media-controls-volume-slider: classes: []
 -webkit-media-controls-toggle-closed-captions-button: classes: [hidden]
 -webkit-media-controls-fullscreen-button: classes: []

Modified: trunk/Source/WebCore/ChangeLog (257835 => 257836)


--- trunk/Source/WebCore/ChangeLog	2020-03-04 06:31:10 UTC (rev 257835)
+++ trunk/Source/WebCore/ChangeLog	2020-03-04 08:54:57 UTC (rev 257836)
@@ -1,3 +1,15 @@
+2020-03-04  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK][WPE] Stop adding volume-box class to volume box element
+        https://bugs.webkit.org/show_bug.cgi?id=208510
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        The class was removed in r257705 because it's not used by our css.
+
+        * Modules/mediacontrols/mediaControlsAdwaita.js:
+        (Controller.prototype.createControls):
+
 2020-03-03  Devin Rousso  <drou...@apple.com>
 
         Web Inspector: re-add `InspectorFrontendHost` support for moving the inspected window

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js (257835 => 257836)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js	2020-03-04 06:31:10 UTC (rev 257835)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js	2020-03-04 08:54:57 UTC (rev 257836)
@@ -268,7 +268,6 @@
         var volumeBox = this.controls.volumeBox = document.createElement('div');
         volumeBox.setAttribute('pseudo', '-webkit-media-controls-volume-slider-container');
         volumeBox.classList.add(this.ClassNames.hiding);
-        volumeBox.classList.add(this.ClassNames.volumeBox);
         this.listenFor(volumeBox, 'mouseover', this.handleMuteButtonMouseOver);
 
         var volume = this.controls.volume = document.createElement('input');
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to