Title: [257859] trunk/Tools
- Revision
- 257859
- Author
- ryanhad...@apple.com
- Date
- 2020-03-04 10:35:28 -0800 (Wed, 04 Mar 2020)
Log Message
[macOS] test-lldb-webkit failing on debug bots
https://bugs.webkit.org/show_bug.cgi?id=208545
Reviewed by Jonathan Bedard.
The lldb-webkit-test step must pass in the build configuration as an
argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
binary that is downloaded with the rest of the build products. Without this
argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
regardless of their actual build configuration.
* BuildSlaveSupport/build.webkit.org-config/steps.py:
(RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
* Scripts/test-lldb-webkit:
(LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (257858 => 257859)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2020-03-04 18:23:41 UTC (rev 257858)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2020-03-04 18:35:28 UTC (rev 257859)
@@ -653,6 +653,7 @@
"./Tools/Scripts/test-lldb-webkit",
"--verbose",
"--no-build",
+ WithProperties("--%(configuration)s"),
]
failedTestsFormatString = "%d lldb test%s failed"
Modified: trunk/Tools/ChangeLog (257858 => 257859)
--- trunk/Tools/ChangeLog 2020-03-04 18:23:41 UTC (rev 257858)
+++ trunk/Tools/ChangeLog 2020-03-04 18:35:28 UTC (rev 257859)
@@ -1,3 +1,21 @@
+2020-03-04 Ryan Haddad <ryanhad...@apple.com>
+
+ [macOS] test-lldb-webkit failing on debug bots
+ https://bugs.webkit.org/show_bug.cgi?id=208545
+
+ Reviewed by Jonathan Bedard.
+
+ The lldb-webkit-test step must pass in the build configuration as an
+ argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
+ binary that is downloaded with the rest of the build products. Without this
+ argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
+ regardless of their actual build configuration.
+
+ * BuildSlaveSupport/build.webkit.org-config/steps.py:
+ (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
+ * Scripts/test-lldb-webkit:
+ (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
+
2020-03-04 Aakash Jain <aakash_j...@apple.com>
[ews] Add build step to create local git commit for commit-queue (follow-up fix)
Modified: trunk/Tools/Scripts/test-lldb-webkit (257858 => 257859)
--- trunk/Tools/Scripts/test-lldb-webkit 2020-03-04 18:23:41 UTC (rev 257858)
+++ trunk/Tools/Scripts/test-lldb-webkit 2020-03-04 18:35:28 UTC (rev 257859)
@@ -70,10 +70,10 @@
default=False, help='Run quietly (errors, warnings, and progress only)')
parser.add_argument('-p', '--pass-through', action='', default=False,
help='Be debugger friendly by passing captured output through to the system')
- parser.add_argument('--debug', const='debug',
+ parser.add_argument('--debug', const='Debug',
dest='configuration', action='',
default=None, help='Alias for configuration=debug.')
- parser.add_argument('--release', const='release',
+ parser.add_argument('--release', const='Release',
dest='configuration', action='',
default=None, help='Alias for configuration=release.')
parser.add_argument('--configuration',
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
