Title: [257901] trunk/Source/WebCore
Revision
257901
Author
sihui_...@apple.com
Date
2020-03-04 21:50:09 -0800 (Wed, 04 Mar 2020)

Log Message

Remove unused variable m_allUniqueIDBDatabases in IDBServer
https://bugs.webkit.org/show_bug.cgi?id=208613

Reviewed by Chris Dumez.

* Modules/indexeddb/server/IDBServer.h:
(WebCore::IDBServer::IDBServer::addDatabase): Deleted.
(WebCore::IDBServer::IDBServer::removeDatabase): Deleted.
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (257900 => 257901)


--- trunk/Source/WebCore/ChangeLog	2020-03-05 05:26:14 UTC (rev 257900)
+++ trunk/Source/WebCore/ChangeLog	2020-03-05 05:50:09 UTC (rev 257901)
@@ -1,3 +1,17 @@
+2020-03-04  Sihui Liu  <sihui_...@apple.com>
+
+        Remove unused variable m_allUniqueIDBDatabases in IDBServer
+        https://bugs.webkit.org/show_bug.cgi?id=208613
+
+        Reviewed by Chris Dumez.
+
+        * Modules/indexeddb/server/IDBServer.h:
+        (WebCore::IDBServer::IDBServer::addDatabase): Deleted.
+        (WebCore::IDBServer::IDBServer::removeDatabase): Deleted.
+        * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+        (WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
+        (WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
+
 2020-03-04  Zalan Bujtas  <za...@apple.com>
 
         [VNE layout] Move visually non-empty content reporting to RenderTreeBuilder

Modified: trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.h (257900 => 257901)


--- trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.h	2020-03-05 05:26:14 UTC (rev 257900)
+++ trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.h	2020-03-05 05:50:09 UTC (rev 257901)
@@ -110,9 +110,6 @@
 
     Lock& lock() { return m_lock; };
 
-    void addDatabase(UniqueIDBDatabase& database) { m_allUniqueIDBDatabases.add(database); }
-    void removeDatabase(UniqueIDBDatabase& database) { m_allUniqueIDBDatabases.remove(database); }
-
 private:
     UniqueIDBDatabase& getOrCreateUniqueIDBDatabase(const IDBDatabaseIdentifier&);
     
@@ -125,7 +122,6 @@
     PAL::SessionID m_sessionID;
     HashMap<IDBConnectionIdentifier, RefPtr<IDBConnectionToClient>> m_connectionMap;
     HashMap<IDBDatabaseIdentifier, std::unique_ptr<UniqueIDBDatabase>> m_uniqueIDBDatabaseMap;
-    WeakHashSet<UniqueIDBDatabase> m_allUniqueIDBDatabases;
 
     HashMap<uint64_t, UniqueIDBDatabaseConnection*> m_databaseConnections;
     HashMap<IDBResourceIdentifier, UniqueIDBDatabaseTransaction*> m_transactions;

Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (257900 => 257901)


--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2020-03-05 05:26:14 UTC (rev 257900)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2020-03-05 05:50:09 UTC (rev 257901)
@@ -116,7 +116,6 @@
 {
     ASSERT(!isMainThread());
 
-    m_server.addDatabase(*this);
     LOG(IndexedDB, "UniqueIDBDatabase::UniqueIDBDatabase() (%p) %s", this, m_identifier.loggingString().utf8().data());
 }
 
@@ -132,8 +131,6 @@
     ASSERT(!m_versionChangeTransaction);
     ASSERT(!m_versionChangeDatabaseConnection);
     RELEASE_ASSERT(!m_backingStore);
-
-    m_server.removeDatabase(*this);
 }
 
 const IDBDatabaseInfo& UniqueIDBDatabase::info() const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to