Title: [257908] trunk/Source/_javascript_Core
- Revision
- 257908
- Author
- commit-qu...@webkit.org
- Date
- 2020-03-05 00:54:49 -0800 (Thu, 05 Mar 2020)
Log Message
[JSCOnly] 32-bits warning on memset of JSValue
https://bugs.webkit.org/show_bug.cgi?id=204411
Patch by Paulo Matos <pma...@igalia.com> on 2020-03-05
Reviewed by Mark Lam.
Fixes warning on 32bit builds. This is required because GCC knows
it is not safe to use memset on non-POD types and warns against its use.
* heap/GCMemoryOperations.h:
(JSC::gcSafeZeroMemory):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (257907 => 257908)
--- trunk/Source/_javascript_Core/ChangeLog 2020-03-05 07:57:21 UTC (rev 257907)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-03-05 08:54:49 UTC (rev 257908)
@@ -1,3 +1,16 @@
+2020-03-05 Paulo Matos <pma...@igalia.com>
+
+ [JSCOnly] 32-bits warning on memset of JSValue
+ https://bugs.webkit.org/show_bug.cgi?id=204411
+
+ Reviewed by Mark Lam.
+
+ Fixes warning on 32bit builds. This is required because GCC knows
+ it is not safe to use memset on non-POD types and warns against its use.
+
+ * heap/GCMemoryOperations.h:
+ (JSC::gcSafeZeroMemory):
+
2020-03-04 Mark Lam <mark....@apple.com>
Handle an out of memory error while constructing the BytecodeGenerator.
Modified: trunk/Source/_javascript_Core/heap/GCMemoryOperations.h (257907 => 257908)
--- trunk/Source/_javascript_Core/heap/GCMemoryOperations.h 2020-03-05 07:57:21 UTC (rev 257907)
+++ trunk/Source/_javascript_Core/heap/GCMemoryOperations.h 2020-03-05 08:54:49 UTC (rev 257908)
@@ -306,7 +306,7 @@
bitwise_cast<volatile uint64_t*>(dst)[i] = 0;
#endif // COMPILER(GCC_COMPATIBLE)
#else
- memset(dst, 0, bytes);
+ memset(reinterpret_cast<char*>(dst), 0, bytes);
#endif // USE(JSVALUE64)
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
