Title: [257925] trunk/Tools
- Revision
- 257925
- Author
- aakash_j...@apple.com
- Date
- 2020-03-05 10:16:22 -0800 (Thu, 05 Mar 2020)
Log Message
[ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
https://bugs.webkit.org/show_bug.cgi?id=208645
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/ews-build/steps.py:
(ValidateCommiterAndReviewer.load_contributors):
(ValidateCommiterAndReviewer.start):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (257924 => 257925)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-03-05 18:10:52 UTC (rev 257924)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-03-05 18:16:22 UTC (rev 257925)
@@ -644,7 +644,7 @@
for key, value in contributors_json.iteritems():
emails = value.get('emails')
for email in emails:
- contributors[email] = {'name': key, 'status': value.get('status')}
+ contributors[email.lower()] = {'name': key, 'status': value.get('status')}
return contributors
@defer.inlineCallbacks
@@ -693,13 +693,13 @@
self.descriptionDone = 'Failed to get contributors information'
self.build.buildFinished(['Failed to get contributors information'], FAILURE)
return None
- patch_committer = self.getProperty('patch_committer', '')
+ patch_committer = self.getProperty('patch_committer', '').lower()
if not self.is_committer(patch_committer):
self.fail_build(patch_committer, 'committer')
return None
self._addToLog('stdio', '{} is a valid commiter.\n'.format(patch_committer))
- patch_reviewer = self.getProperty('patch_reviewer', '')
+ patch_reviewer = self.getProperty('patch_reviewer', '').lower()
if not patch_reviewer:
# Patch does not have r+ flag. This is acceptable, since the ChangeLog might have 'Reviewed by' in it.
self.descriptionDone = 'Validated committer'
Modified: trunk/Tools/ChangeLog (257924 => 257925)
--- trunk/Tools/ChangeLog 2020-03-05 18:10:52 UTC (rev 257924)
+++ trunk/Tools/ChangeLog 2020-03-05 18:16:22 UTC (rev 257925)
@@ -1,3 +1,14 @@
+2020-03-05 Aakash Jain <aakash_j...@apple.com>
+
+ [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
+ https://bugs.webkit.org/show_bug.cgi?id=208645
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (ValidateCommiterAndReviewer.load_contributors):
+ (ValidateCommiterAndReviewer.start):
+
2020-03-05 Carlos Alberto Lopez Perez <clo...@igalia.com>
style-checker: Add UAF to the list of security words to warn about.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
