Title: [257973] trunk/Tools
- Revision
- 257973
- Author
- [email protected]
- Date
- 2020-03-06 02:02:27 -0800 (Fri, 06 Mar 2020)
Log Message
[WPE][WebDriver] MiniBrowser should react to close session commands
https://bugs.webkit.org/show_bug.cgi?id=207529
Reviewed by Carlos Garcia Campos.
Do not call g_object_unref on the first created view if it has already
been disposed in the "close" signal handler.
Based on original patch by Yury Semikhatsky.
* MiniBrowser/wpe/main.cpp:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (257972 => 257973)
--- trunk/Tools/ChangeLog 2020-03-06 09:49:53 UTC (rev 257972)
+++ trunk/Tools/ChangeLog 2020-03-06 10:02:27 UTC (rev 257973)
@@ -1,3 +1,18 @@
+2020-03-06 Lauro Moura <[email protected]>
+
+ [WPE][WebDriver] MiniBrowser should react to close session commands
+ https://bugs.webkit.org/show_bug.cgi?id=207529
+
+ Reviewed by Carlos Garcia Campos.
+
+ Do not call g_object_unref on the first created view if it has already
+ been disposed in the "close" signal handler.
+
+ Based on original patch by Yury Semikhatsky.
+
+ * MiniBrowser/wpe/main.cpp:
+ (main):
+
2020-03-06 Michael Catanzaro <[email protected]>
[WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
Modified: trunk/Tools/MiniBrowser/wpe/main.cpp (257972 => 257973)
--- trunk/Tools/MiniBrowser/wpe/main.cpp 2020-03-06 09:49:53 UTC (rev 257972)
+++ trunk/Tools/MiniBrowser/wpe/main.cpp 2020-03-06 10:02:27 UTC (rev 257973)
@@ -288,6 +288,7 @@
"is-controlled-by-automation", automationMode,
nullptr));
g_object_unref(settings);
+ g_object_add_weak_pointer(G_OBJECT(webView), reinterpret_cast<void**>(&webView));
backendPtr->setInputClient(std::make_unique<InputClient>(loop, webView));
#if defined(HAVE_ACCESSIBILITY) && HAVE_ACCESSIBILITY
@@ -326,7 +327,10 @@
g_main_loop_run(loop);
- g_object_unref(webView);
+ if (webView) {
+ g_object_remove_weak_pointer(G_OBJECT(webView), reinterpret_cast<void**>(&webView));
+ g_object_unref(webView);
+ }
if (privateMode || automationMode)
g_object_unref(webContext);
g_main_loop_unref(loop);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
