Diff
Modified: trunk/LayoutTests/ChangeLog (257977 => 257978)
--- trunk/LayoutTests/ChangeLog 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/LayoutTests/ChangeLog 2020-03-06 14:22:08 UTC (rev 257978)
@@ -1,3 +1,15 @@
+2020-03-06 Antoine Quint <[email protected]>
+
+ Remove the experimental flag for Pointer Events
+ https://bugs.webkit.org/show_bug.cgi?id=208655
+ <rdar://problem/60090545>
+
+ Reviewed by Dean Jackson.
+
+ * fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html:
+ * pointerevents/disabled-expected.html: Removed.
+ * pointerevents/disabled.html: Removed.
+
2020-03-06 Enrique Ocaña González <[email protected]>
[GStreamer] Streaming aac/mp3 audio doesn't always work
Modified: trunk/LayoutTests/fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html (257977 => 257978)
--- trunk/LayoutTests/fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/LayoutTests/fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html 2020-03-06 14:22:08 UTC (rev 257978)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ experimental:PointerEventsEnabled=true ] -->
+<!DOCTYPE html>
<html>
<head>
<script src=""
Deleted: trunk/LayoutTests/pointerevents/disabled-expected.html (257977 => 257978)
--- trunk/LayoutTests/pointerevents/disabled-expected.html 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/LayoutTests/pointerevents/disabled-expected.html 2020-03-06 14:22:08 UTC (rev 257978)
@@ -1,3 +0,0 @@
-<!DOCTYPE html>
-<p>The PointerEvent interface shouldn't be visible when the feature is disabled.</p>
-<p>window.PointerEvent == <span>undefined</span></p>
Deleted: trunk/LayoutTests/pointerevents/disabled.html (257977 => 257978)
--- trunk/LayoutTests/pointerevents/disabled.html 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/LayoutTests/pointerevents/disabled.html 2020-03-06 14:22:08 UTC (rev 257978)
@@ -1,9 +0,0 @@
-<!DOCTYPE html><!-- webkit-test-runner [ experimental:PointerEventsEnabled=false ] -->
-<p>The PointerEvent interface shouldn't be visible when the feature is disabled.</p>
-<p>window.PointerEvent == <span></span></p>
-<script>
-window.addEventListener("load", () => {
- const output = document.querySelector("span");
- output.textContent = `${window.PointerEvent}`;
-}, false);
-</script>
Modified: trunk/Source/WebCore/ChangeLog (257977 => 257978)
--- trunk/Source/WebCore/ChangeLog 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebCore/ChangeLog 2020-03-06 14:22:08 UTC (rev 257978)
@@ -1,3 +1,23 @@
+2020-03-06 Antoine Quint <[email protected]>
+
+ Remove the experimental flag for Pointer Events
+ https://bugs.webkit.org/show_bug.cgi?id=208655
+ <rdar://problem/60090545>
+
+ Reviewed by Dean Jackson.
+
+ * dom/Element.cpp:
+ (WebCore::dispatchPointerEventIfNeeded):
+ (WebCore::Element::removedFromAncestor):
+ * dom/Element.idl:
+ * dom/NavigatorMaxTouchPoints.idl:
+ * dom/PointerEvent.idl:
+ * page/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setPointerEventsEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::pointerEventsEnabled const): Deleted.
+ * style/StyleTreeResolver.cpp:
+ (WebCore::Style::TreeResolver::resolveElement):
+
2020-03-06 Enrique Ocaña González <[email protected]>
[GStreamer] Streaming aac/mp3 audio doesn't always work
Modified: trunk/Source/WebCore/dom/Element.cpp (257977 => 257978)
--- trunk/Source/WebCore/dom/Element.cpp 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebCore/dom/Element.cpp 2020-03-06 14:22:08 UTC (rev 257978)
@@ -320,27 +320,25 @@
static ShouldIgnoreMouseEvent dispatchPointerEventIfNeeded(Element& element, const MouseEvent& mouseEvent, const PlatformMouseEvent& platformEvent, bool& didNotSwallowEvent)
{
#if ENABLE(POINTER_EVENTS)
- if (RuntimeEnabledFeatures::sharedFeatures().pointerEventsEnabled()) {
- if (auto* page = element.document().page()) {
- auto& pointerCaptureController = page->pointerCaptureController();
+ if (auto* page = element.document().page()) {
+ auto& pointerCaptureController = page->pointerCaptureController();
#if ENABLE(TOUCH_EVENTS)
- if (platformEvent.pointerId() != mousePointerID && mouseEvent.type() != eventNames().clickEvent && pointerCaptureController.preventsCompatibilityMouseEventsForIdentifier(platformEvent.pointerId()))
- return ShouldIgnoreMouseEvent::Yes;
+ if (platformEvent.pointerId() != mousePointerID && mouseEvent.type() != eventNames().clickEvent && pointerCaptureController.preventsCompatibilityMouseEventsForIdentifier(platformEvent.pointerId()))
+ return ShouldIgnoreMouseEvent::Yes;
#else
- UNUSED_PARAM(platformEvent);
+ UNUSED_PARAM(platformEvent);
#endif
- if (platformEvent.syntheticClickType() != NoTap)
- return ShouldIgnoreMouseEvent::No;
+ if (platformEvent.syntheticClickType() != NoTap)
+ return ShouldIgnoreMouseEvent::No;
- if (auto pointerEvent = pointerCaptureController.pointerEventForMouseEvent(mouseEvent)) {
- pointerCaptureController.dispatchEvent(*pointerEvent, &element);
- if (isCompatibilityMouseEvent(mouseEvent) && pointerCaptureController.preventsCompatibilityMouseEventsForIdentifier(pointerEvent->pointerId()))
+ if (auto pointerEvent = pointerCaptureController.pointerEventForMouseEvent(mouseEvent)) {
+ pointerCaptureController.dispatchEvent(*pointerEvent, &element);
+ if (isCompatibilityMouseEvent(mouseEvent) && pointerCaptureController.preventsCompatibilityMouseEventsForIdentifier(pointerEvent->pointerId()))
+ return ShouldIgnoreMouseEvent::Yes;
+ if (pointerEvent->defaultPrevented() || pointerEvent->defaultHandled()) {
+ didNotSwallowEvent = false;
+ if (pointerEvent->type() == eventNames().pointerdownEvent)
return ShouldIgnoreMouseEvent::Yes;
- if (pointerEvent->defaultPrevented() || pointerEvent->defaultHandled()) {
- didNotSwallowEvent = false;
- if (pointerEvent->type() == eventNames().pointerdownEvent)
- return ShouldIgnoreMouseEvent::Yes;
- }
}
}
}
@@ -2200,7 +2198,7 @@
document().page()->pointerLockController().elementRemoved(*this);
#endif
#if ENABLE(POINTER_EVENTS)
- if (document().page() && RuntimeEnabledFeatures::sharedFeatures().pointerEventsEnabled())
+ if (document().page())
document().page()->pointerCaptureController().elementWasRemoved(*this);
#endif
Modified: trunk/Source/WebCore/dom/Element.idl (257977 => 257978)
--- trunk/Source/WebCore/dom/Element.idl 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebCore/dom/Element.idl 2020-03-06 14:22:08 UTC (rev 257978)
@@ -100,9 +100,9 @@
[Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, DisabledByQuirk=shouldDisableElementFullscreen] void webkitRequestFullscreen(); // Prefixed W3C version.
// Extensions from Pointer Events API (https://w3c.github.io/pointerevents/#extensions-to-the-element-interface).
- [Conditional=POINTER_EVENTS, EnabledAtRuntime=PointerEvents, MayThrowException] void setPointerCapture(long pointerId);
- [Conditional=POINTER_EVENTS, EnabledAtRuntime=PointerEvents, MayThrowException] void releasePointerCapture(long pointerId);
- [Conditional=POINTER_EVENTS, EnabledAtRuntime=PointerEvents] boolean hasPointerCapture(long pointerId);
+ [Conditional=POINTER_EVENTS, MayThrowException] void setPointerCapture(long pointerId);
+ [Conditional=POINTER_EVENTS, MayThrowException] void releasePointerCapture(long pointerId);
+ [Conditional=POINTER_EVENTS] boolean hasPointerCapture(long pointerId);
// Extensions from Pointer Lock API (https://w3c.github.io/pointerlock/#extensions-to-the-element-interface).
[Conditional=POINTER_LOCK] void requestPointerLock();
Modified: trunk/Source/WebCore/dom/NavigatorMaxTouchPoints.idl (257977 => 257978)
--- trunk/Source/WebCore/dom/NavigatorMaxTouchPoints.idl 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebCore/dom/NavigatorMaxTouchPoints.idl 2020-03-06 14:22:08 UTC (rev 257978)
@@ -28,8 +28,7 @@
[
NoInterfaceObject,
- Conditional=POINTER_EVENTS,
- EnabledAtRuntime=PointerEvents
+ Conditional=POINTER_EVENTS
] interface MaxTouchPoints {
readonly attribute long maxTouchPoints;
};
Modified: trunk/Source/WebCore/dom/PointerEvent.idl (257977 => 257978)
--- trunk/Source/WebCore/dom/PointerEvent.idl 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebCore/dom/PointerEvent.idl 2020-03-06 14:22:08 UTC (rev 257978)
@@ -38,7 +38,6 @@
[
Conditional=POINTER_EVENTS,
- EnabledAtRuntime=PointerEvents,
DisabledByQuirk=shouldDisablePointerEvents,
Constructor(DOMString type, optional PointerEventInit eventInitDict),
Exposed=Window
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (257977 => 257978)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2020-03-06 14:22:08 UTC (rev 257978)
@@ -174,9 +174,6 @@
void setCSSCustomPropertiesAndValuesEnabled(bool isEnabled) { m_CSSCustomPropertiesAndValuesEnabled = isEnabled; }
bool cssCustomPropertiesAndValuesEnabled() const { return m_CSSCustomPropertiesAndValuesEnabled; }
- void setPointerEventsEnabled(bool isEnabled) { m_pointerEventsEnabled = isEnabled; }
- bool pointerEventsEnabled() const { return m_pointerEventsEnabled; }
-
void setSyntheticEditingCommandsEnabled(bool isEnabled) { m_syntheticEditingCommandsEnabled = isEnabled; }
bool syntheticEditingCommandsEnabled() const { return m_syntheticEditingCommandsEnabled; }
@@ -452,7 +449,6 @@
bool m_attrStyleEnabled { false };
bool m_webAPIStatisticsEnabled { false };
bool m_CSSCustomPropertiesAndValuesEnabled { false };
- bool m_pointerEventsEnabled { true };
bool m_syntheticEditingCommandsEnabled { true };
bool m_dialogElementEnabled { false };
bool m_webSQLEnabled { false };
Modified: trunk/Source/WebCore/style/StyleTreeResolver.cpp (257977 => 257978)
--- trunk/Source/WebCore/style/StyleTreeResolver.cpp 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebCore/style/StyleTreeResolver.cpp 2020-03-06 14:22:08 UTC (rev 257978)
@@ -246,7 +246,7 @@
#if ENABLE(POINTER_EVENTS) && PLATFORM(IOS_FAMILY)
// FIXME: Track this exactly.
- if (update.style->touchActions() != TouchAction::Auto && !m_document.quirks().shouldDisablePointerEventsQuirk() && RuntimeEnabledFeatures::sharedFeatures().pointerEventsEnabled())
+ if (update.style->touchActions() != TouchAction::Auto && !m_document.quirks().shouldDisablePointerEventsQuirk())
m_document.setMayHaveElementsWithNonAutoTouchAction();
#endif
Modified: trunk/Source/WebKit/ChangeLog (257977 => 257978)
--- trunk/Source/WebKit/ChangeLog 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebKit/ChangeLog 2020-03-06 14:22:08 UTC (rev 257978)
@@ -1,3 +1,13 @@
+2020-03-06 Antoine Quint <[email protected]>
+
+ Remove the experimental flag for Pointer Events
+ https://bugs.webkit.org/show_bug.cgi?id=208655
+ <rdar://problem/60090545>
+
+ Reviewed by Dean Jackson.
+
+ * Shared/WebPreferences.yaml:
+
2020-03-05 Brent Fulgham <[email protected]>
[iOS] Remove reporting for some well-understood framebuffer routines
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (257977 => 257978)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-03-06 14:22:08 UTC (rev 257978)
@@ -1310,14 +1310,6 @@
humanReadableDescription: "Enable Visual Viewport API"
category: experimental
-PointerEventsEnabled:
- type: bool
- defaultValue: true
- humanReadableName: "Pointer Events"
- humanReadableDescription: "Enable Pointer Events"
- webcoreBinding: RuntimeEnabledFeatures
- category: experimental
-
SyntheticEditingCommandsEnabled:
type: bool
defaultValue: true
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (257977 => 257978)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-03-06 14:22:08 UTC (rev 257978)
@@ -1,3 +1,21 @@
+2020-03-06 Antoine Quint <[email protected]>
+
+ Remove the experimental flag for Pointer Events
+ https://bugs.webkit.org/show_bug.cgi?id=208655
+ <rdar://problem/60090545>
+
+ Reviewed by Dean Jackson.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences syntheticEditingCommandsEnabled]):
+ (-[WebPreferences setSyntheticEditingCommandsEnabled:]):
+ (-[WebPreferences pointerEventsEnabled]): Deleted.
+ (-[WebPreferences setPointerEventsEnabled:]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+
2020-03-05 youenn fablet <[email protected]>
Export NowPlaying commands to GPUProcess when media playing in GPUProcess is enabled
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (257977 => 257978)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-03-06 14:22:08 UTC (rev 257978)
@@ -55,7 +55,6 @@
#define WebKitWebAnimationsEnabledPreferenceKey @"WebKitWebAnimationsEnabled"
#define WebKitWebAnimationsCompositeOperationsEnabledPreferenceKey @"WebKitWebAnimationsCompositeOperationsEnabled"
#define WebKitWebAnimationsMutableTimelinesEnabledPreferenceKey @"WebKitWebAnimationsMutableTimelinesEnabled"
-#define WebKitPointerEventsEnabledPreferenceKey @"WebKitPointerEventsEnabled"
#define WebKitSyntheticEditingCommandsEnabledPreferenceKey @"WebKitSyntheticEditingCommandsEnabled"
#define WebKitWebSecurityEnabledPreferenceKey @"WebKitWebSecurityEnabled"
#define WebKitAllowUniversalAccessFromFileURLsPreferenceKey @"WebKitAllowUniversalAccessFromFileURLs"
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (257977 => 257978)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-03-06 14:22:08 UTC (rev 257978)
@@ -657,7 +657,6 @@
#endif
@NO, WebKitDirectoryUploadEnabledPreferenceKey,
@YES, WebKitWebAnimationsEnabledPreferenceKey,
- @YES, WebKitPointerEventsEnabledPreferenceKey,
@YES, WebKitSyntheticEditingCommandsEnabledPreferenceKey,
#if PLATFORM(IOS_FAMILY)
@@ -3238,24 +3237,14 @@
[self _setBoolValue:flag forKey:WebKitWebAnimationsMutableTimelinesEnabledPreferenceKey];
}
-- (BOOL)pointerEventsEnabled
-{
- return [self _boolValueForKey:WebKitPointerEventsEnabledPreferenceKey];
-}
-
-- (void)setPointerEventsEnabled:(BOOL)flag
-{
- [self _setBoolValue:flag forKey:WebKitPointerEventsEnabledPreferenceKey];
-}
-
- (BOOL)syntheticEditingCommandsEnabled
{
- return [self _boolValueForKey:WebKitPointerEventsEnabledPreferenceKey];
+ return [self _boolValueForKey:WebKitSyntheticEditingCommandsEnabledPreferenceKey];
}
- (void)setSyntheticEditingCommandsEnabled:(BOOL)flag
{
- [self _setBoolValue:flag forKey:WebKitPointerEventsEnabledPreferenceKey];
+ [self _setBoolValue:flag forKey:WebKitSyntheticEditingCommandsEnabledPreferenceKey];
}
- (BOOL)fetchAPIKeepAliveEnabled
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (257977 => 257978)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-03-06 14:22:08 UTC (rev 257978)
@@ -586,9 +586,6 @@
- (void)setWebAnimationsMutableTimelinesEnabled:(BOOL)flag;
- (BOOL)webAnimationsMutableTimelinesEnabled;
-- (void)setPointerEventsEnabled:(BOOL)flag;
-- (BOOL)pointerEventsEnabled;
-
- (void)setSyntheticEditingCommandsEnabled:(BOOL)flag;
- (BOOL)syntheticEditingCommandsEnabled;
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (257977 => 257978)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-03-06 12:41:27 UTC (rev 257977)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-03-06 14:22:08 UTC (rev 257978)
@@ -3186,10 +3186,6 @@
RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsCompositeOperationsEnabled([preferences webAnimationsCompositeOperationsEnabled]);
RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsMutableTimelinesEnabled([preferences webAnimationsMutableTimelinesEnabled]);
-#if ENABLE(POINTER_EVENTS)
- RuntimeEnabledFeatures::sharedFeatures().setPointerEventsEnabled([preferences pointerEventsEnabled]);
-#endif
-
#if ENABLE(INTERSECTION_OBSERVER)
RuntimeEnabledFeatures::sharedFeatures().setIntersectionObserverEnabled(preferences.intersectionObserverEnabled);
#endif
