Title: [257992] releases/WebKitGTK/webkit-2.28
- Revision
- 257992
- Author
- carlo...@webkit.org
- Date
- 2020-03-06 06:28:52 -0800 (Fri, 06 Mar 2020)
Log Message
Merge r257972 - [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
https://bugs.webkit.org/show_bug.cgi?id=208647
Patch by Michael Catanzaro <mcatanz...@gnome.org> on 2020-03-06
Reviewed by Carlos Garcia Campos.
Source/WebCore:
I had previously determined that we need to send a Firefox user agent quirk to
accounts.youtube.com to avoid unsupported browser warnings on Google Docs. Either the user
agent check has since become more aggressive, or it somehow depends on factors I don't
understand, but as of today it's no longer enough. We now need the quirk for docs.google.com
as well.
* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresFirefoxBrowser):
Tools:
* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog (257991 => 257992)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-03-06 14:28:47 UTC (rev 257991)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-03-06 14:28:52 UTC (rev 257992)
@@ -1,3 +1,19 @@
+2020-03-06 Michael Catanzaro <mcatanz...@gnome.org>
+
+ [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
+ https://bugs.webkit.org/show_bug.cgi?id=208647
+
+ Reviewed by Carlos Garcia Campos.
+
+ I had previously determined that we need to send a Firefox user agent quirk to
+ accounts.youtube.com to avoid unsupported browser warnings on Google Docs. Either the user
+ agent check has since become more aggressive, or it somehow depends on factors I don't
+ understand, but as of today it's no longer enough. We now need the quirk for docs.google.com
+ as well.
+
+ * platform/UserAgentQuirks.cpp:
+ (WebCore::urlRequiresFirefoxBrowser):
+
2020-03-04 Doug Kelly <do...@apple.com>
Crash in SVGElement::removeEventListener with symbol element
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/UserAgentQuirks.cpp (257991 => 257992)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/UserAgentQuirks.cpp 2020-03-06 14:28:47 UTC (rev 257991)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/UserAgentQuirks.cpp 2020-03-06 14:28:52 UTC (rev 257992)
@@ -85,7 +85,7 @@
// to reproduce the warnings you will need to sign out of Google, then click
// on a link to a non-public document that requires signing in. The
// unsupported browser warning will be displayed after signing in.
- if (domain == "accounts.youtube.com")
+ if (domain == "accounts.youtube.com" || domain == "docs.google.com")
return true;
// Google Drive shows an unsupported browser warning with WebKitGTK's
Modified: releases/WebKitGTK/webkit-2.28/Tools/ChangeLog (257991 => 257992)
--- releases/WebKitGTK/webkit-2.28/Tools/ChangeLog 2020-03-06 14:28:47 UTC (rev 257991)
+++ releases/WebKitGTK/webkit-2.28/Tools/ChangeLog 2020-03-06 14:28:52 UTC (rev 257992)
@@ -1,3 +1,13 @@
+2020-03-06 Michael Catanzaro <mcatanz...@gnome.org>
+
+ [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
+ https://bugs.webkit.org/show_bug.cgi?id=208647
+
+ Reviewed by Carlos Garcia Campos.
+
+ * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+ (TestWebKitAPI::TEST):
+
2020-02-21 Michael Catanzaro <mcatanz...@gnome.org>
[WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
Modified: releases/WebKitGTK/webkit-2.28/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (257991 => 257992)
--- releases/WebKitGTK/webkit-2.28/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp 2020-03-06 14:28:47 UTC (rev 257991)
+++ releases/WebKitGTK/webkit-2.28/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp 2020-03-06 14:28:52 UTC (rev 257992)
@@ -92,6 +92,7 @@
assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
assertUserAgentForURLHasFirefoxBrowserQuirk("http://accounts.youtube.com/");
+ assertUserAgentForURLHasFirefoxBrowserQuirk("http://docs.google.com/");
assertUserAgentForURLHasFirefoxBrowserQuirk("http://drive.google.com/");
assertUserAgentForURLHasLinuxPlatformQuirk("http://www.google.com/");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
