Title: [257995] trunk/Source/WebKit
- Revision
- 257995
- Author
- [email protected]
- Date
- 2020-03-06 06:49:38 -0800 (Fri, 06 Mar 2020)
Log Message
[GPUP] Set the WebProcess's useGPUProcessForMedia setting during the first page load
https://bugs.webkit.org/show_bug.cgi?id=208694
Reviewed by Youenn Fablet.
Until such a time as we can pass through the correct preference during WebProcess creation,
set the WebProcess's "useGPUProcessForMedia" setting just before the first page load.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/WebProcess.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (257994 => 257995)
--- trunk/Source/WebKit/ChangeLog 2020-03-06 14:29:02 UTC (rev 257994)
+++ trunk/Source/WebKit/ChangeLog 2020-03-06 14:49:38 UTC (rev 257995)
@@ -1,3 +1,19 @@
+2020-03-06 Jer Noble <[email protected]>
+
+ [GPUP] Set the WebProcess's useGPUProcessForMedia setting during the first page load
+ https://bugs.webkit.org/show_bug.cgi?id=208694
+
+ Reviewed by Youenn Fablet.
+
+ Until such a time as we can pass through the correct preference during WebProcess creation,
+ set the WebProcess's "useGPUProcessForMedia" setting just before the first page load.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::initializeWebProcess):
+ * WebProcess/WebProcess.h:
+
2020-03-06 Antoine Quint <[email protected]>
Remove the experimental flag for Pointer Events
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (257994 => 257995)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2020-03-06 14:29:02 UTC (rev 257994)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2020-03-06 14:49:38 UTC (rev 257995)
@@ -3727,6 +3727,7 @@
// FIXME: useGPUProcessForMedia should be a RuntimeEnabledFeature since it's global.
static_cast<WebMediaStrategy&>(platformStrategies()->mediaStrategy()).setUseGPUProcess(settings.useGPUProcessForMedia());
WebProcess::singleton().supplement<RemoteMediaPlayerManager>()->updatePreferences(settings);
+ WebProcess::singleton().setUseGPUProcessForMedia(settings.useGPUProcessForMedia());
#endif
}
Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (257994 => 257995)
--- trunk/Source/WebKit/WebProcess/WebProcess.cpp 2020-03-06 14:29:02 UTC (rev 257994)
+++ trunk/Source/WebKit/WebProcess/WebProcess.cpp 2020-03-06 14:49:38 UTC (rev 257995)
@@ -472,8 +472,6 @@
WebResourceLoadObserver::setShouldLogUserInteraction(parameters.shouldLogUserInteraction);
#endif
- setUseGPUProcessForMedia(parameters.useGPUProcessForMedia);
-
RELEASE_LOG_IF_ALLOWED(Process, "initializeWebProcess: Presenting process = %d", WebCore::presentingApplicationPID());
}
Modified: trunk/Source/WebKit/WebProcess/WebProcess.h (257994 => 257995)
--- trunk/Source/WebKit/WebProcess/WebProcess.h 2020-03-06 14:29:02 UTC (rev 257994)
+++ trunk/Source/WebKit/WebProcess/WebProcess.h 2020-03-06 14:49:38 UTC (rev 257995)
@@ -333,6 +333,8 @@
void updatePageScreenProperties();
#endif
+ void setUseGPUProcessForMedia(bool);
+
private:
WebProcess();
~WebProcess();
@@ -517,8 +519,6 @@
bool isAlwaysOnLoggingAllowed() { return m_sessionID ? m_sessionID->isAlwaysOnLoggingAllowed() : true; }
- void setUseGPUProcessForMedia(bool);
-
RefPtr<WebConnectionToUIProcess> m_webConnection;
HashMap<WebCore::PageIdentifier, RefPtr<WebPage>> m_pageMap;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
