Title: [258029] trunk/Source/WebKit
- Revision
- 258029
- Author
- [email protected]
- Date
- 2020-03-06 14:13:28 -0800 (Fri, 06 Mar 2020)
Log Message
[GPUP] Enable Picture-in-Picture support on Mac
https://bugs.webkit.org/show_bug.cgi?id=208732
Reviewed by Eric Carlson.
Covered by existing tests.
RemoteMediaPlayerProxy needs to send "hasVideo" state to MediaPlayerPrivateRemote
in the Web process in order to enable the Picture-in-Picture mode support (on Mac).
* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::updateCachedState):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258028 => 258029)
--- trunk/Source/WebKit/ChangeLog 2020-03-06 21:57:14 UTC (rev 258028)
+++ trunk/Source/WebKit/ChangeLog 2020-03-06 22:13:28 UTC (rev 258029)
@@ -1,5 +1,20 @@
2020-03-06 Peng Liu <[email protected]>
+ [GPUP] Enable Picture-in-Picture support on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=208732
+
+ Reviewed by Eric Carlson.
+
+ Covered by existing tests.
+
+ RemoteMediaPlayerProxy needs to send "hasVideo" state to MediaPlayerPrivateRemote
+ in the Web process in order to enable the Picture-in-Picture mode support (on Mac).
+
+ * GPUProcess/media/RemoteMediaPlayerProxy.cpp:
+ (WebKit::RemoteMediaPlayerProxy::updateCachedState):
+
+2020-03-06 Peng Liu <[email protected]>
+
Use the feature flags mechanism to give default feature preference values
https://bugs.webkit.org/show_bug.cgi?id=208607
Modified: trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp (258028 => 258029)
--- trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp 2020-03-06 21:57:14 UTC (rev 258028)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp 2020-03-06 22:13:28 UTC (rev 258029)
@@ -680,6 +680,7 @@
m_cachedState.paused = m_player->paused();
m_cachedState.loadingProgressed = m_player->didLoadingProgress();
m_cachedState.hasAudio = m_player->hasAudio();
+ m_cachedState.hasVideo = m_player->hasVideo();
if (m_bufferedChanged) {
m_bufferedChanged = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
