Title: [258149] trunk/Source/WebKit
Revision
258149
Author
ddkil...@apple.com
Date
2020-03-09 12:50:32 -0700 (Mon, 09 Mar 2020)

Log Message

[IPC] WebPageProxy::dataSelectionForPasteboard should check the result of SharedMemory::map
<https://webkit.org/b/208735>
<rdar://problem/58701732>

Reviewed by Darin Adler.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::dataSelectionForPasteboard): Add null
check.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (258148 => 258149)


--- trunk/Source/WebKit/ChangeLog	2020-03-09 19:35:03 UTC (rev 258148)
+++ trunk/Source/WebKit/ChangeLog	2020-03-09 19:50:32 UTC (rev 258149)
@@ -1,3 +1,15 @@
+2020-03-09  David Kilzer  <ddkil...@apple.com>
+
+        [IPC] WebPageProxy::dataSelectionForPasteboard should check the result of SharedMemory::map
+        <https://webkit.org/b/208735>
+        <rdar://problem/58701732>
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/mac/WebPageProxyMac.mm:
+        (WebKit::WebPageProxy::dataSelectionForPasteboard): Add null
+        check.
+
 2020-03-09  Antoine Quint  <grao...@apple.com>
 
         Remove the compile-time flag for Pointer Events

Modified: trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm (258148 => 258149)


--- trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm	2020-03-09 19:35:03 UTC (rev 258148)
+++ trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm	2020-03-09 19:50:32 UTC (rev 258149)
@@ -255,6 +255,8 @@
     if (handle.isNull())
         return nullptr;
     RefPtr<SharedMemory> sharedMemoryBuffer = SharedMemory::map(handle, SharedMemory::Protection::ReadOnly);
+    if (!sharedMemoryBuffer)
+        return nullptr;
     return SharedBuffer::create(static_cast<unsigned char *>(sharedMemoryBuffer->data()), size);
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to