Title: [258277] trunk/Source/WebKit
- Revision
- 258277
- Author
- cdu...@apple.com
- Date
- 2020-03-11 13:19:07 -0700 (Wed, 11 Mar 2020)
Log Message
Terminate the Network / Plugin processes when receiving invalid IPC from them
https://bugs.webkit.org/show_bug.cgi?id=208933
<rdar://problem/58026473>
Reviewed by Geoffrey Garen.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveInvalidMessage):
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didReceiveInvalidMessage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258276 => 258277)
--- trunk/Source/WebKit/ChangeLog 2020-03-11 20:09:27 UTC (rev 258276)
+++ trunk/Source/WebKit/ChangeLog 2020-03-11 20:19:07 UTC (rev 258277)
@@ -1,3 +1,16 @@
+2020-03-11 Chris Dumez <cdu...@apple.com>
+
+ Terminate the Network / Plugin processes when receiving invalid IPC from them
+ https://bugs.webkit.org/show_bug.cgi?id=208933
+ <rdar://problem/58026473>
+
+ Reviewed by Geoffrey Garen.
+
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::didReceiveInvalidMessage):
+ * UIProcess/Plugins/PluginProcessProxy.cpp:
+ (WebKit::PluginProcessProxy::didReceiveInvalidMessage):
+
2020-03-11 Timothy Horton <timothy_hor...@apple.com>
Fix the macCatalyst build after r258250
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (258276 => 258277)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2020-03-11 20:09:27 UTC (rev 258276)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2020-03-11 20:19:07 UTC (rev 258277)
@@ -315,6 +315,7 @@
void NetworkProcessProxy::didReceiveInvalidMessage(IPC::Connection& connection, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
{
logInvalidMessage(connection, messageReceiverName, messageName);
+ terminate();
}
void NetworkProcessProxy::processAuthenticationChallenge(PAL::SessionID sessionID, Ref<AuthenticationChallengeProxy>&& authenticationChallenge)
Modified: trunk/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp (258276 => 258277)
--- trunk/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp 2020-03-11 20:09:27 UTC (rev 258276)
+++ trunk/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp 2020-03-11 20:19:07 UTC (rev 258277)
@@ -217,6 +217,7 @@
void PluginProcessProxy::didReceiveInvalidMessage(IPC::Connection& connection, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
{
logInvalidMessage(connection, messageReceiverName, messageName);
+ terminate();
}
void PluginProcessProxy::didFinishLaunching(ProcessLauncher*, IPC::Connection::Identifier connectionIdentifier)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
