Title: [258294] trunk/Source/WebKit
- Revision
- 258294
- Author
- pvol...@apple.com
- Date
- 2020-03-11 16:27:19 -0700 (Wed, 11 Mar 2020)
Log Message
[macOS] _AXSApplicationAccessibilityEnabled should not be called
https://bugs.webkit.org/show_bug.cgi?id=208953
Reviewed by Brent Fulgham.
This function should only be called on iOS, not on macOS.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258293 => 258294)
--- trunk/Source/WebKit/ChangeLog 2020-03-11 22:42:08 UTC (rev 258293)
+++ trunk/Source/WebKit/ChangeLog 2020-03-11 23:27:19 UTC (rev 258294)
@@ -1,3 +1,17 @@
+2020-03-11 Per Arne Vollan <pvol...@apple.com>
+
+ [macOS] _AXSApplicationAccessibilityEnabled should not be called
+ https://bugs.webkit.org/show_bug.cgi?id=208953
+
+ Reviewed by Brent Fulgham.
+
+ This function should only be called on iOS, not on macOS.
+
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::platformInitializeWebProcess):
+ * UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+ (WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
2020-03-11 Jiewen Tan <jiewen_...@apple.com>
[WebAuthn] Formalize the Keychain schema
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258293 => 258294)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-03-11 22:42:08 UTC (rev 258293)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-03-11 23:27:19 UTC (rev 258294)
@@ -455,7 +455,10 @@
}
#if ENABLE(CFPREFS_DIRECT_MODE)
- if (libAccessibilityLibrary() && _AXSApplicationAccessibilityEnabled()) {
+#if PLATFORM(IOS_FAMILY)
+ if (_AXSApplicationAccessibilityEnabled())
+#endif
+ {
SandboxExtension::Handle preferencesExtensionHandle;
SandboxExtension::createHandleForMachLookup("com.apple.cfprefsd.daemon", WTF::nullopt, preferencesExtensionHandle);
parameters.preferencesExtensionHandle = WTFMove(preferencesExtensionHandle);
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258293 => 258294)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-03-11 22:42:08 UTC (rev 258293)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-03-11 23:27:19 UTC (rev 258294)
@@ -46,10 +46,6 @@
namespace WebKit {
-#if PLATFORM(MAC)
-SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
-#endif
-
static const Seconds unexpectedActivityDuration = 10_s;
const HashSet<String>& WebProcessProxy::platformPathsWithAssumedReadAccess()
@@ -214,12 +210,10 @@
{
if (m_hasSentMessageToUnblockAccessibilityServer)
return;
-#if PLATFORM(MAC)
- if (!WebKit::libAccessibilityLibrary())
+#if PLATFORM(IOS_FAMILY)
+ if (!_AXSApplicationAccessibilityEnabled())
return;
#endif
- if (!_AXSApplicationAccessibilityEnabled())
- return;
if (!processIdentifier())
return;
if (!canSendMessage())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
