Title: [258304] trunk/Source/WebKit
- Revision
- 258304
- Author
- pvol...@apple.com
- Date
- 2020-03-11 18:22:17 -0700 (Wed, 11 Mar 2020)
Log Message
[macOS] Register with accessibility when the WebContent process starts
https://bugs.webkit.org/show_bug.cgi?id=208960
Reviewed by Brent Fulgham.
When we reenabled CF prefs direct mode in <https://bugs.webkit.org/show_bug.cgi?id=208690>, we started to register
with accessibility when we received a message to do so from the UI process. This would typically happen when the user
enabled accessibility. On macOS, this notification does not work the same way as on iOS, and it is assumed that
accessibility should always be enabled. Therefore we should go back to registering with accessibility on startup of
the WebContent process on macOS.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::unblockAccessibilityServer):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258303 => 258304)
--- trunk/Source/WebKit/ChangeLog 2020-03-12 01:22:09 UTC (rev 258303)
+++ trunk/Source/WebKit/ChangeLog 2020-03-12 01:22:17 UTC (rev 258304)
@@ -1,3 +1,20 @@
+2020-03-11 Per Arne Vollan <pvol...@apple.com>
+
+ [macOS] Register with accessibility when the WebContent process starts
+ https://bugs.webkit.org/show_bug.cgi?id=208960
+
+ Reviewed by Brent Fulgham.
+
+ When we reenabled CF prefs direct mode in <https://bugs.webkit.org/show_bug.cgi?id=208690>, we started to register
+ with accessibility when we received a message to do so from the UI process. This would typically happen when the user
+ enabled accessibility. On macOS, this notification does not work the same way as on iOS, and it is assumed that
+ accessibility should always be enabled. Therefore we should go back to registering with accessibility on startup of
+ the WebContent process on macOS.
+
+ * WebProcess/cocoa/WebProcessCocoa.mm:
+ (WebKit::WebProcess::platformInitializeProcess):
+ (WebKit::WebProcess::unblockAccessibilityServer):
+
2020-03-11 Don Olmstead <don.olmst...@sony.com>
[GPUP] RemoteAudioDestination classes should require ENABLE(WEB_AUDIO)
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (258303 => 258304)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2020-03-12 01:22:09 UTC (rev 258303)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2020-03-12 01:22:17 UTC (rev 258304)
@@ -528,6 +528,10 @@
else
m_processType = ProcessType::WebContent;
+#if PLATFORM(MAC)
+ registerWithAccessibility();
+#endif
+
#if USE(OS_STATE)
registerWithStateDumper();
#endif
@@ -976,9 +980,9 @@
#if PLATFORM(IOS_FAMILY)
bool ok = SandboxExtension::consumePermanently(handle);
ASSERT_UNUSED(ok, ok);
-#endif
registerWithAccessibility();
+#endif
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes