Title: [258387] trunk/Source/_javascript_Core
- Revision
- 258387
- Author
- ysuz...@apple.com
- Date
- 2020-03-13 00:57:16 -0700 (Fri, 13 Mar 2020)
Log Message
Unreviewed, change ASSERT to ASSERT_WITH_SECURITY_IMPLICATION since it is now enabled under ENABLE(SECURITY_ASSERTIONS)
https://bugs.webkit.org/show_bug.cgi?id=209041
<rdar://problem/59705631>
* runtime/JSCast.h:
(JSC::jsCast):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (258386 => 258387)
--- trunk/Source/_javascript_Core/ChangeLog 2020-03-13 07:53:28 UTC (rev 258386)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-03-13 07:57:16 UTC (rev 258387)
@@ -1,3 +1,12 @@
+2020-03-13 Yusuke Suzuki <ysuz...@apple.com>
+
+ Unreviewed, change ASSERT to ASSERT_WITH_SECURITY_IMPLICATION since it is now enabled under ENABLE(SECURITY_ASSERTIONS)
+ https://bugs.webkit.org/show_bug.cgi?id=209041
+ <rdar://problem/59705631>
+
+ * runtime/JSCast.h:
+ (JSC::jsCast):
+
2020-03-12 Yusuke Suzuki <ysuz...@apple.com>
Report crashed cell in jsCast in debug builds
Modified: trunk/Source/_javascript_Core/runtime/JSCast.h (258386 => 258387)
--- trunk/Source/_javascript_Core/runtime/JSCast.h 2020-03-13 07:53:28 UTC (rev 258386)
+++ trunk/Source/_javascript_Core/runtime/JSCast.h 2020-03-13 07:57:16 UTC (rev 258387)
@@ -47,7 +47,7 @@
{
static_assert(std::is_base_of<JSCell, typename std::remove_pointer<To>::type>::value, "JS casting expects that the types you are casting to is a subclass of JSCell");
#if (ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)) && CPU(X86_64)
- ASSERT(from.isCell());
+ ASSERT_WITH_SECURITY_IMPLICATION(from.isCell());
JSCell* cell = from.asCell();
if (!cell->JSCell::inherits(cell->vm(), std::remove_pointer<To>::type::info()))
reportZappedCellAndCrash(*cell->JSCell::heap(), cell);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
