Title: [258831] trunk/Source
- Revision
- 258831
- Author
- [email protected]
- Date
- 2020-03-23 03:57:14 -0700 (Mon, 23 Mar 2020)
Log Message
[WPE] AsyncScrolling: horizontal scrolling is inverted
https://bugs.webkit.org/show_bug.cgi?id=208638
Source/WebCore:
Patch by Carlos Garcia Campos <[email protected]> on 2020-03-23
Reviewed by Adrian Perez de Castro.
Scrolling down should scroll to the right and up to the left..
* page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent): Invert also the x axis.
* page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent): Ditto.
Source/WebKit:
Patch by Chris Lord <[email protected]> on 2020-03-23
Reviewed by Adrian Perez de Castro.
* UIProcess/API/wpe/ScrollGestureController.cpp:
(WebKit::ScrollGestureController::handleEvent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (258830 => 258831)
--- trunk/Source/WebCore/ChangeLog 2020-03-23 10:49:46 UTC (rev 258830)
+++ trunk/Source/WebCore/ChangeLog 2020-03-23 10:57:14 UTC (rev 258831)
@@ -1,3 +1,17 @@
+2020-03-23 Carlos Garcia Campos <[email protected]>
+
+ [WPE] AsyncScrolling: horizontal scrolling is inverted
+ https://bugs.webkit.org/show_bug.cgi?id=208638
+
+ Reviewed by Adrian Perez de Castro.
+
+ Scrolling down should scroll to the right and up to the left..
+
+ * page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
+ (WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent): Invert also the x axis.
+ * page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:
+ (WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent): Ditto.
+
2020-03-23 Antoine Quint <[email protected]>
[Web Animations] Fix the typo for ElementAnimationRareData::completedTransitionByProperty()
Modified: trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp (258830 => 258831)
--- trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp 2020-03-23 10:49:46 UTC (rev 258830)
+++ trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp 2020-03-23 10:57:14 UTC (rev 258831)
@@ -107,7 +107,7 @@
auto& compositionLayer = downcast<Nicosia::CompositionLayer>(*scrollLayer);
auto updateScope = compositionLayer.createUpdateScope();
- scrollBy({ wheelEvent.deltaX(), -wheelEvent.deltaY() });
+ scrollBy({ -wheelEvent.deltaX(), -wheelEvent.deltaY() });
}
scrollingTree().setOrClearLatchedNode(wheelEvent, scrollingNodeID());
Modified: trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp (258830 => 258831)
--- trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp 2020-03-23 10:49:46 UTC (rev 258830)
+++ trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp 2020-03-23 10:57:14 UTC (rev 258831)
@@ -93,7 +93,7 @@
auto& compositionLayer = downcast<Nicosia::CompositionLayer>(*scrollLayer);
auto updateScope = compositionLayer.createUpdateScope();
- scrollBy({ wheelEvent.deltaX(), -wheelEvent.deltaY() });
+ scrollBy({ -wheelEvent.deltaX(), -wheelEvent.deltaY() });
}
scrollingTree().setOrClearLatchedNode(wheelEvent, scrollingNodeID());
Modified: trunk/Source/WebKit/ChangeLog (258830 => 258831)
--- trunk/Source/WebKit/ChangeLog 2020-03-23 10:49:46 UTC (rev 258830)
+++ trunk/Source/WebKit/ChangeLog 2020-03-23 10:57:14 UTC (rev 258831)
@@ -1,3 +1,13 @@
+2020-03-23 Chris Lord <[email protected]>
+
+ [WPE] AsyncScrolling: horizontal scrolling is inverted
+ https://bugs.webkit.org/show_bug.cgi?id=208638
+
+ Reviewed by Adrian Perez de Castro.
+
+ * UIProcess/API/wpe/ScrollGestureController.cpp:
+ (WebKit::ScrollGestureController::handleEvent):
+
2020-03-23 youenn fablet <[email protected]>
Explicitly activate the new DrawingAreaProxy on PSON navigation
Modified: trunk/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp (258830 => 258831)
--- trunk/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp 2020-03-23 10:49:46 UTC (rev 258830)
+++ trunk/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp 2020-03-23 10:57:14 UTC (rev 258831)
@@ -58,7 +58,7 @@
touchPoint->time, m_start.x, m_start.y,
0, 0, 0,
};
- m_axisEvent.x_axis = m_offset.x - touchPoint->x;
+ m_axisEvent.x_axis = -(m_offset.x - touchPoint->x);
m_axisEvent.y_axis = -(m_offset.y - touchPoint->y);
#else
m_axisEvent = {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
