Title: [258890] trunk/Source/WebCore
Revision
258890
Author
[email protected]
Date
2020-03-23 17:06:29 -0700 (Mon, 23 Mar 2020)

Log Message

Add console message when legacy TLS is used
https://bugs.webkit.org/show_bug.cgi?id=209444

Patch by Alex Christensen <[email protected]> on 2020-03-23
Reviewed by Darin Adler.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponse):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (258889 => 258890)


--- trunk/Source/WebCore/ChangeLog	2020-03-23 23:48:51 UTC (rev 258889)
+++ trunk/Source/WebCore/ChangeLog	2020-03-24 00:06:29 UTC (rev 258890)
@@ -1,3 +1,13 @@
+2020-03-23  Alex Christensen  <[email protected]>
+
+        Add console message when legacy TLS is used
+        https://bugs.webkit.org/show_bug.cgi?id=209444
+
+        Reviewed by Darin Adler.
+
+        * loader/ResourceLoader.cpp:
+        (WebCore::ResourceLoader::didReceiveResponse):
+
 2020-03-23  John Wilander  <[email protected]>
 
         Add the capability to change all of a website's cookies to SameSite=Strict

Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (258889 => 258890)


--- trunk/Source/WebCore/loader/ResourceLoader.cpp	2020-03-23 23:48:51 UTC (rev 258889)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp	2020-03-24 00:06:29 UTC (rev 258890)
@@ -45,6 +45,7 @@
 #include "LoaderStrategy.h"
 #include "Logging.h"
 #include "Page.h"
+#include "PageConsoleClient.h"
 #include "PlatformStrategies.h"
 #include "ProgressTracker.h"
 #include "ResourceError.h"
@@ -502,8 +503,13 @@
 
     if (r.usedLegacyTLS()) {
         if (m_frame) {
-            if (auto* document = m_frame->document())
-                document->setUsedLegacyTLS(true);
+            if (auto* document = m_frame->document()) {
+                if (!document->usedLegacyTLS()) {
+                    if (auto* page = document->page())
+                        page->console().addMessage(MessageSource::Network, MessageLevel::Warning, "Loaded resource using TLS 1.0 or 1.1, which are deprecated protocols that will be removed. Please use TLS 1.2 or newer instead."_s, 0, document);
+                    document->setUsedLegacyTLS(true);
+                }
+            }
         }
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to