Title: [258893] trunk/Tools
- Revision
- 258893
- Author
- [email protected]
- Date
- 2020-03-23 18:22:34 -0700 (Mon, 23 Mar 2020)
Log Message
Fix memory leak introduced in r257726
https://bugs.webkit.org/show_bug.cgi?id=208399
Patch by Alex Christensen <[email protected]> on 2020-03-23
Reviewed by John Wilander.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::websiteDataStore):
We were leaking page configurations.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (258892 => 258893)
--- trunk/Tools/ChangeLog 2020-03-24 00:42:31 UTC (rev 258892)
+++ trunk/Tools/ChangeLog 2020-03-24 01:22:34 UTC (rev 258893)
@@ -1,3 +1,14 @@
+2020-03-23 Alex Christensen <[email protected]>
+
+ Fix memory leak introduced in r257726
+ https://bugs.webkit.org/show_bug.cgi?id=208399
+
+ Reviewed by John Wilander.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::websiteDataStore):
+ We were leaking page configurations.
+
2020-03-23 John Wilander <[email protected]>
Add the capability to change all of a website's cookies to SameSite=Strict
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (258892 => 258893)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-03-24 00:42:31 UTC (rev 258892)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-03-24 01:22:34 UTC (rev 258893)
@@ -550,7 +550,7 @@
WKWebsiteDataStoreRef TestController::websiteDataStore()
{
- return WKPageConfigurationGetWebsiteDataStore(WKPageCopyPageConfiguration(m_mainWebView->page()));
+ return WKPageConfigurationGetWebsiteDataStore(adoptWK(WKPageCopyPageConfiguration(m_mainWebView->page())).get());
}
WKRetainPtr<WKPageConfigurationRef> TestController::generatePageConfiguration(const TestOptions& options)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
