Title: [258975] trunk/Source/WebCore
- Revision
- 258975
- Author
- ctur...@igalia.com
- Date
- 2020-03-25 03:19:09 -0700 (Wed, 25 Mar 2020)
Log Message
[GStreamer] Remove noisy warning about broken LC support
https://bugs.webkit.org/show_bug.cgi?id=209472
Reviewed by Philippe Normand.
* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::initializeGStreamer): There's no seemingly nice way of
ensuring this message is issued once in WebKit the
lifetime. Issuing multiple times is upsetting users. We can't rely
on Gst logging at this point, and there's no established story of
using the LOG_CHANNEL stuff on WPE/GTK ports for suppressible
WebKit message AFAICT.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (258974 => 258975)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 06:00:23 UTC (rev 258974)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 10:19:09 UTC (rev 258975)
@@ -1,3 +1,18 @@
+2020-03-25 Charlie Turner <ctur...@igalia.com>
+
+ [GStreamer] Remove noisy warning about broken LC support
+ https://bugs.webkit.org/show_bug.cgi?id=209472
+
+ Reviewed by Philippe Normand.
+
+ * platform/graphics/gstreamer/GStreamerCommon.cpp:
+ (WebCore::initializeGStreamer): There's no seemingly nice way of
+ ensuring this message is issued once in WebKit the
+ lifetime. Issuing multiple times is upsetting users. We can't rely
+ on Gst logging at this point, and there's no established story of
+ using the LOG_CHANNEL stuff on WPE/GTK ports for suppressible
+ WebKit message AFAICT.
+
2020-03-24 Andres Gonzalez <andresg...@apple.com>
Avoid multiple unnecessary updates of the IsolatedTree.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp (258974 => 258975)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2020-03-25 06:00:23 UTC (rev 258974)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2020-03-25 10:19:09 UTC (rev 258975)
@@ -268,8 +268,7 @@
if (avAACDecoderFactory)
gst_plugin_feature_set_rank(GST_PLUGIN_FEATURE_CAST(avAACDecoderFactory.get()), GST_RANK_MARGINAL);
}
- } else
- WTFLogAlways("WARNING: You might have broken LC support in your AAC decoders, consider installing fdkaacdec");
+ }
#endif
});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
