Title: [259060] trunk/Tools
Revision
259060
Author
cfleiz...@apple.com
Date
2020-03-26 11:44:59 -0700 (Thu, 26 Mar 2020)

Log Message

AX: WKTR: Don't update isolated tree mode behavior if not required
https://bugs.webkit.org/show_bug.cgi?id=209555
<rdar://problem/60885094>

Reviewed by Darin Adler.

If the isolated tree mode has not changed, then we should not poke at the mechanisms for turning it on/off.
This might have the side effect of turning on accessibility unexpectedly.

* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (259059 => 259060)


--- trunk/Tools/ChangeLog	2020-03-26 18:41:49 UTC (rev 259059)
+++ trunk/Tools/ChangeLog	2020-03-26 18:44:59 UTC (rev 259060)
@@ -1,3 +1,17 @@
+2020-03-26  Chris Fleizach  <cfleiz...@apple.com>
+
+        AX: WKTR: Don't update isolated tree mode behavior if not required
+        https://bugs.webkit.org/show_bug.cgi?id=209555
+        <rdar://problem/60885094>
+
+        Reviewed by Darin Adler.
+
+        If the isolated tree mode has not changed, then we should not poke at the mechanisms for turning it on/off.
+        This might have the side effect of turning on accessibility unexpectedly.
+
+        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
+        (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
+
 2020-03-26  Philippe Normand  <pnorm...@igalia.com>
 
         [Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp (259059 => 259060)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp	2020-03-26 18:41:49 UTC (rev 259059)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp	2020-03-26 18:44:59 UTC (rev 259060)
@@ -57,8 +57,10 @@
 #if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
 void AccessibilityController::setAccessibilityIsolatedTreeMode(bool flag)
 {
-    m_accessibilityIsolatedTreeMode = flag;
-    updateIsolatedTreeMode();
+    if (m_accessibilityIsolatedTreeMode != flag) {
+        m_accessibilityIsolatedTreeMode = flag;
+        updateIsolatedTreeMode();
+    }
 }
 
 void AccessibilityController::updateIsolatedTreeMode()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to