Title: [259081] trunk/Source/WebCore
- Revision
- 259081
- Author
- cdu...@apple.com
- Date
- 2020-03-26 14:36:35 -0700 (Thu, 26 Mar 2020)
Log Message
[StressGC] ASSERTION FAILED: m_wrapper under WebCore::HTMLMediaElement::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=209616
<rdar://problem/60541294>
Reviewed by Saam Barati.
HTMLMediaElement::hasPendingActivity() should return true if there are pending tasks on
m_playbackTargetIsWirelessQueue since the tasks we enqueue there dispatch events.
No new tests, covered by media/modern-media-controls/placard-support/placard-support-airplay.html.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasPendingActivity const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (259080 => 259081)
--- trunk/Source/WebCore/ChangeLog 2020-03-26 21:33:33 UTC (rev 259080)
+++ trunk/Source/WebCore/ChangeLog 2020-03-26 21:36:35 UTC (rev 259081)
@@ -1,5 +1,21 @@
2020-03-26 Chris Dumez <cdu...@apple.com>
+ [StressGC] ASSERTION FAILED: m_wrapper under WebCore::HTMLMediaElement::dispatchEvent
+ https://bugs.webkit.org/show_bug.cgi?id=209616
+ <rdar://problem/60541294>
+
+ Reviewed by Saam Barati.
+
+ HTMLMediaElement::hasPendingActivity() should return true if there are pending tasks on
+ m_playbackTargetIsWirelessQueue since the tasks we enqueue there dispatch events.
+
+ No new tests, covered by media/modern-media-controls/placard-support/placard-support-airplay.html.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::hasPendingActivity const):
+
+2020-03-26 Chris Dumez <cdu...@apple.com>
+
[ Mac wk1] ASSERTION FAILED: m_wrapper under WebCore::XMLHttpRequestUpload::dispatchProgressEvent
https://bugs.webkit.org/show_bug.cgi?id=209560
<rdar://problem/60887773>
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (259080 => 259081)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2020-03-26 21:33:33 UTC (rev 259080)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2020-03-26 21:36:35 UTC (rev 259081)
@@ -5764,7 +5764,7 @@
bool HTMLMediaElement::hasPendingActivity() const
{
- return (hasAudio() && isPlaying()) || m_asyncEventQueue->hasPendingEvents() || m_creatingControls;
+ return (hasAudio() && isPlaying()) || m_asyncEventQueue->hasPendingEvents() || m_playbackTargetIsWirelessQueue.hasPendingTasks() || m_creatingControls;
}
void HTMLMediaElement::mediaVolumeDidChange()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
