Title: [259176] trunk/Source/WebKit
- Revision
- 259176
- Author
- [email protected]
- Date
- 2020-03-29 01:52:38 -0700 (Sun, 29 Mar 2020)
Log Message
REGRESSION (r257867): [GPUP] Use-after-move in RemoteCDMInstance::createSession()
<https://webkit.org/b/209712>
<rdar://problem/61018795>
Reviewed by Darin Adler.
* WebProcess/GPU/media/RemoteCDMInstance.cpp:
(WebKit::RemoteCDMInstance::createSession): Fix use-after-move
by using RemoteCDMInstanceSession::identifier().
* WebProcess/GPU/media/RemoteCDMInstanceSession.h:
(RemoteCDMInstanceSession::identifier): Add getter.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (259175 => 259176)
--- trunk/Source/WebKit/ChangeLog 2020-03-29 06:13:39 UTC (rev 259175)
+++ trunk/Source/WebKit/ChangeLog 2020-03-29 08:52:38 UTC (rev 259176)
@@ -1,3 +1,17 @@
+2020-03-29 David Kilzer <[email protected]>
+
+ REGRESSION (r257867): [GPUP] Use-after-move in RemoteCDMInstance::createSession()
+ <https://webkit.org/b/209712>
+ <rdar://problem/61018795>
+
+ Reviewed by Darin Adler.
+
+ * WebProcess/GPU/media/RemoteCDMInstance.cpp:
+ (WebKit::RemoteCDMInstance::createSession): Fix use-after-move
+ by using RemoteCDMInstanceSession::identifier().
+ * WebProcess/GPU/media/RemoteCDMInstanceSession.h:
+ (RemoteCDMInstanceSession::identifier): Add getter.
+
2020-03-28 Devin Rousso <[email protected]>
Web Inspector: support editing cookie key/values from inspector
Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteCDMInstance.cpp (259175 => 259176)
--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteCDMInstance.cpp 2020-03-29 06:13:39 UTC (rev 259175)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteCDMInstance.cpp 2020-03-29 08:52:38 UTC (rev 259176)
@@ -91,7 +91,7 @@
if (!id)
return nullptr;
auto session = RemoteCDMInstanceSession::create(makeWeakPtr(m_factory.get()), WTFMove(id));
- m_factory->addSession(id, session.copyRef());
+ m_factory->addSession(session->identifier(), session.copyRef());
return session;
}
Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteCDMInstanceSession.h (259175 => 259176)
--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteCDMInstanceSession.h 2020-03-29 06:13:39 UTC (rev 259175)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteCDMInstanceSession.h 2020-03-29 08:52:38 UTC (rev 259176)
@@ -43,6 +43,8 @@
static Ref<RemoteCDMInstanceSession> create(WeakPtr<RemoteCDMFactory>&&, RemoteCDMInstanceSessionIdentifier&&);
virtual ~RemoteCDMInstanceSession() = default;
+ RemoteCDMInstanceSessionIdentifier identifier() const { return m_identifier; }
+
private:
friend class RemoteCDMFactory;
RemoteCDMInstanceSession(WeakPtr<RemoteCDMFactory>&&, RemoteCDMInstanceSessionIdentifier&&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
