Title: [259446] trunk/Tools
- Revision
- 259446
- Author
- an...@apple.com
- Date
- 2020-04-03 00:08:42 -0700 (Fri, 03 Apr 2020)
Log Message
[Windows] Ignore render tree dump based results on Windows
https://bugs.webkit.org/show_bug.cgi?id=209897
Reviewed by Darin Adler.
Render tree dumps are port specific and so difficult to maintain. They are mostly very old and
have been superseded by more modern ref and text dump tests. They rarely reveal any port specific bugs.
This patch adds --ignore-render-tree-dump-results option to run-webkit-tests and enables it by
default on Apple Windows port.
With the option set the render tree dump tests are still run (so crashes are detected) but their
output is treated as if it always passed. Missing results are not written to disk.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_text):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(_set_up_derived_options):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (259445 => 259446)
--- trunk/Tools/ChangeLog 2020-04-03 07:04:45 UTC (rev 259445)
+++ trunk/Tools/ChangeLog 2020-04-03 07:08:42 UTC (rev 259446)
@@ -1,3 +1,25 @@
+2020-04-03 Antti Koivisto <an...@apple.com>
+
+ [Windows] Ignore render tree dump based results on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=209897
+
+ Reviewed by Darin Adler.
+
+ Render tree dumps are port specific and so difficult to maintain. They are mostly very old and
+ have been superseded by more modern ref and text dump tests. They rarely reveal any port specific bugs.
+
+ This patch adds --ignore-render-tree-dump-results option to run-webkit-tests and enables it by
+ default on Apple Windows port.
+
+ With the option set the render tree dump tests are still run (so crashes are detected) but their
+ output is treated as if it always passed. Missing results are not written to disk.
+
+ * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+ (SingleTestRunner._compare_text):
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+ (parse_args):
+ (_set_up_derived_options):
+
2020-04-02 James Savage <james.sav...@apple.com>
Add myself, as a committer, to contributors.json.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (259445 => 259446)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2020-04-03 07:04:45 UTC (rev 259445)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2020-04-03 07:08:42 UTC (rev 259446)
@@ -235,6 +235,8 @@
def _compare_text(self, expected_text, actual_text):
failures = []
+ if self._options.ignore_render_tree_dump_results and self._render_tree_dump_pattern.match(actual_text):
+ return failures
if (expected_text and actual_text and
# Assuming expected_text is already normalized.
self._port.do_text_results_differ(expected_text, self._get_normalized_output_text(actual_text))):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (259445 => 259446)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2020-04-03 07:04:45 UTC (rev 259445)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2020-04-03 07:08:42 UTC (rev 259446)
@@ -149,6 +149,9 @@
dest="sample_on_timeout", help="Don't run sample on timeout (OS X only)"),
optparse.make_option("--no-ref-tests", action=""
dest="no_ref_tests", help="Skip all ref tests"),
+ optparse.make_option("--ignore-render-tree-dump-results", action=""
+ dest="ignore_render_tree_dump_results",
+ help="Don't compare or save results for render tree dump tests (they still run and crashes are reported)"),
optparse.make_option("--tolerance",
help="Ignore image differences less than this percentage (some "
"ports may ignore this option)", type="float"),
@@ -469,6 +472,10 @@
if options.platform in ["gtk", "wpe"]:
options.webkit_test_runner = True
+ # Don't maintain render tree dump results for Apple Windows port.
+ if port.port_name == "win":
+ options.ignore_render_tree_dump_results = True
+
if options.leaks:
options.additional_env_var.append("JSC_usePoisoning=0")
options.additional_env_var.append("__XPC_JSC_usePoisoning=0")
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
