Title: [259454] trunk/JSTests
Revision
259454
Author
[email protected]
Date
2020-04-03 05:09:12 -0700 (Fri, 03 Apr 2020)

Log Message

Re-enable previously skipped arm tests
https://bugs.webkit.org/show_bug.cgi?id=209958

Patch by Paulo Matos <[email protected]> on 2020-04-03
Reviewed by Adrian Perez de Castro.

In the past year, some arm tests were skipped to keep the bots green.
All known issues affecting these tests were fixed and now can be unskipped.

* stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js:
* stress/dont-range-based-iterate-vector-that-is-mutated.js:
* stress/generator-cell-with-type.js:
* stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js:
* stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js:
* stress/sampling-profiler-should-not-sample-beyond-stack-bounds.js:
* stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js:
* stress/toctou-having-a-bad-time-new-array.js:

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (259453 => 259454)


--- trunk/JSTests/ChangeLog	2020-04-03 11:10:37 UTC (rev 259453)
+++ trunk/JSTests/ChangeLog	2020-04-03 12:09:12 UTC (rev 259454)
@@ -1,5 +1,24 @@
 2020-04-03  Paulo Matos  <[email protected]>
 
+        Re-enable previously skipped arm tests
+        https://bugs.webkit.org/show_bug.cgi?id=209958
+
+        Reviewed by Adrian Perez de Castro.
+
+        In the past year, some arm tests were skipped to keep the bots green.
+        All known issues affecting these tests were fixed and now can be unskipped.
+
+        * stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js:
+        * stress/dont-range-based-iterate-vector-that-is-mutated.js:
+        * stress/generator-cell-with-type.js:
+        * stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js:
+        * stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js:
+        * stress/sampling-profiler-should-not-sample-beyond-stack-bounds.js:
+        * stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js:
+        * stress/toctou-having-a-bad-time-new-array.js:
+
+2020-04-03  Paulo Matos  <[email protected]>
+
         stress/ftl-gettypedarrayoffset-wasteful.js times out on arm/linux
         https://bugs.webkit.org/show_bug.cgi?id=198754
 

Modified: trunk/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js (259453 => 259454)


--- trunk/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js	2020-04-03 11:10:37 UTC (rev 259453)
+++ trunk/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js	2020-04-03 12:09:12 UTC (rev 259454)
@@ -1,4 +1,4 @@
-//@ skip if ["arm", "mips"].include?($architecture)
+//@ skip if ["mips"].include?($architecture)
 //@ slow!
 //@ runDefault("--jitPolicyScale=0")
 

Modified: trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js (259453 => 259454)


--- trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js	2020-04-03 11:10:37 UTC (rev 259453)
+++ trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js	2020-04-03 12:09:12 UTC (rev 259454)
@@ -1,4 +1,4 @@
-//@ skip if not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux"
+//@ skip if not $jitTests and $architecture =~ /mips/ and $hostOS == "linux"
 // Should not crash when run with ASAN.
 
 function foo(arr1, arr2) {

Modified: trunk/JSTests/stress/generator-cell-with-type.js (259453 => 259454)


--- trunk/JSTests/stress/generator-cell-with-type.js	2020-04-03 11:10:37 UTC (rev 259453)
+++ trunk/JSTests/stress/generator-cell-with-type.js	2020-04-03 12:09:12 UTC (rev 259454)
@@ -1,5 +1,5 @@
-// This test takes too long on arm and mips devices.
-//@ skip if ["arm", "mips"].include?($architecture)
+// This test takes too long on mips devices.
+//@ skip if ["mips"].include?($architecture)
 function shouldBe(actual, expected) {
     if (actual !== expected)
         throw new Error('bad value: ' + actual);

Modified: trunk/JSTests/stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js (259453 => 259454)


--- trunk/JSTests/stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js	2020-04-03 11:10:37 UTC (rev 259453)
+++ trunk/JSTests/stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js	2020-04-03 12:09:12 UTC (rev 259454)
@@ -1,4 +1,4 @@
-//@ skip if $hostOS == "playstation" or $architecture == "arm"
+//@ skip if $hostOS == "playstation"
 //@ runDefault("--gcIncrementScale=100", "--gcIncrementBytes=10", "--numberOfGCMarkers=1")
 
 let a = [];

Modified: trunk/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js (259453 => 259454)


--- trunk/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js	2020-04-03 11:10:37 UTC (rev 259453)
+++ trunk/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js	2020-04-03 12:09:12 UTC (rev 259454)
@@ -1,5 +1,5 @@
 //@ requireOptions("--jitPolicyScale=0")
-//@ skip if ["arm", "mips"].include?($architecture)
+//@ skip if ["mips"].include?($architecture)
 //@ slow!
 
 for (let j = 0; j < 500; j++) {

Modified: trunk/JSTests/stress/sampling-profiler-should-not-sample-beyond-stack-bounds.js (259453 => 259454)


--- trunk/JSTests/stress/sampling-profiler-should-not-sample-beyond-stack-bounds.js	2020-04-03 11:10:37 UTC (rev 259453)
+++ trunk/JSTests/stress/sampling-profiler-should-not-sample-beyond-stack-bounds.js	2020-04-03 12:09:12 UTC (rev 259454)
@@ -1,4 +1,3 @@
-//@ skip if $architecture == "arm"
 //@ requireOptions("--useSamplingProfiler=true", "--useProbeOSRExit=true", "--useObjectAllocationSinking=false", "--sampleInterval=10")
 
 function foo(ranges) {

Modified: trunk/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js (259453 => 259454)


--- trunk/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js	2020-04-03 11:10:37 UTC (rev 259453)
+++ trunk/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js	2020-04-03 12:09:12 UTC (rev 259454)
@@ -1,4 +1,4 @@
-//@ skip if $buildType == "debug" || ["arm", "mips"].include?($architecture)
+//@ skip if $buildType == "debug" || ["mips"].include?($architecture)
 //@ slow!
 //@ runDefault("--collectContinuously=1", "--slowPathAllocsBetweenGCs=100")
 

Modified: trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js (259453 => 259454)


--- trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js	2020-04-03 11:10:37 UTC (rev 259453)
+++ trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js	2020-04-03 12:09:12 UTC (rev 259454)
@@ -1,4 +1,4 @@
-//@ skip if $buildType == "debug" or ["arm", "mips"].include?($architecture)
+//@ skip if $buildType == "debug" or ["mips"].include?($architecture)
 
 let code = `
     function foo() {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to