Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (259456 => 259457)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-04-03 14:11:17 UTC (rev 259456)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-04-03 14:17:15 UTC (rev 259457)
@@ -1621,6 +1621,7 @@
resultDirectory = 'layout-test-results'
jsonFileName = 'layout-test-results/full_results.json'
logfiles = {'json': jsonFileName}
+ test_failures_log_name = 'test-failures'
command = ['python', 'Tools/Scripts/run-webkit-tests',
'--no-build',
'--no-show-results',
@@ -1667,6 +1668,14 @@
return match_object.group('message')
return line
+ @defer.inlineCallbacks
+ def _addToLog(self, logName, message):
+ try:
+ log = self.getLog(logName)
+ except KeyError:
+ log = yield self.addLog(logName)
+ log.addStdout(message)
+
def _parseRunWebKitTestsOutput(self, logText):
incorrectLayoutLines = []
expressions = [
@@ -1705,6 +1714,8 @@
if first_results:
self.setProperty('first_results_exceed_failure_limit', first_results.did_exceed_test_failure_limit)
self.setProperty('first_run_failures', first_results.failing_tests)
+ if first_results.failing_tests:
+ self._addToLog(self.test_failures_log_name, '\n'.join(first_results.failing_tests))
self._parseRunWebKitTestsOutput(logText)
def evaluateResult(self, cmd):
@@ -1804,6 +1815,8 @@
if second_results:
self.setProperty('second_results_exceed_failure_limit', second_results.did_exceed_test_failure_limit)
self.setProperty('second_run_failures', second_results.failing_tests)
+ if second_results.failing_tests:
+ self._addToLog(self.test_failures_log_name, '\n'.join(second_results.failing_tests))
self._parseRunWebKitTestsOutput(logText)
@@ -1825,6 +1838,8 @@
if clean_tree_results:
self.setProperty('clean_tree_results_exceed_failure_limit', clean_tree_results.did_exceed_test_failure_limit)
self.setProperty('clean_tree_run_failures', clean_tree_results.failing_tests)
+ if clean_tree_results.failing_tests:
+ self._addToLog(self.test_failures_log_name, '\n'.join(clean_tree_results.failing_tests))
self._parseRunWebKitTestsOutput(logText)
Modified: trunk/Tools/ChangeLog (259456 => 259457)
--- trunk/Tools/ChangeLog 2020-04-03 14:11:17 UTC (rev 259456)
+++ trunk/Tools/ChangeLog 2020-04-03 14:17:15 UTC (rev 259457)
@@ -1,3 +1,16 @@
+2020-04-03 Aakash Jain <[email protected]>
+
+ [ews] Display list of test failures along-with the layout-test build step
+ https://bugs.webkit.org/show_bug.cgi?id=209912
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (RunWebKitTests._addToLog):
+ (RunWebKitTests.commandComplete): Add list of test failures to 'test-failures' log which is displayed in UI.
+ (ReRunWebKitTests.commandComplete): Ditto.
+ (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
+
2020-04-03 Philippe Normand <[email protected]>
REGRESSION(r259453): [Flatpak SDK] Build directory no longer bind-mounted when running tests
