Title: [259465] trunk/Source
- Revision
- 259465
- Author
- [email protected]
- Date
- 2020-04-03 09:43:13 -0700 (Fri, 03 Apr 2020)
Log Message
Add logging to help diagnose <webkit.org/b/209685>
https://bugs.webkit.org/show_bug.cgi?id=209967
Reviewed by Darin Adler.
Source/WebCore:
Add logging to try and diagnose a handful of API test failures on iOS 13.4 test runners. The failures seem to
only reproduce in release builds on one particular bot; even then, the problem still doesn't reproduce when
running the API tests on this failing bot.
As such, add some logging to try and verify whether...
(1) the UI process is even attempting to update its supported item provider types, which should happen after
each drag session update.
(2) WKContentView is receiving calls to update the drag session in the first place.
* platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard updateSupportedTypeIdentifiers:]):
Source/WebKit:
See WebCore/ChangeLog.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dropInteraction:sessionDidUpdate:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (259464 => 259465)
--- trunk/Source/WebCore/ChangeLog 2020-04-03 16:26:51 UTC (rev 259464)
+++ trunk/Source/WebCore/ChangeLog 2020-04-03 16:43:13 UTC (rev 259465)
@@ -1,3 +1,22 @@
+2020-04-03 Wenson Hsieh <[email protected]>
+
+ Add logging to help diagnose <webkit.org/b/209685>
+ https://bugs.webkit.org/show_bug.cgi?id=209967
+
+ Reviewed by Darin Adler.
+
+ Add logging to try and diagnose a handful of API test failures on iOS 13.4 test runners. The failures seem to
+ only reproduce in release builds on one particular bot; even then, the problem still doesn't reproduce when
+ running the API tests on this failing bot.
+
+ As such, add some logging to try and verify whether...
+ (1) the UI process is even attempting to update its supported item provider types, which should happen after
+ each drag session update.
+ (2) WKContentView is receiving calls to update the drag session in the first place.
+
+ * platform/ios/WebItemProviderPasteboard.mm:
+ (-[WebItemProviderPasteboard updateSupportedTypeIdentifiers:]):
+
2020-04-03 Sihui Liu <[email protected]>
ASSERTION FAILED: m_delegate in IDBConnectionToClient::identifier()
Modified: trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm (259464 => 259465)
--- trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm 2020-04-03 16:26:51 UTC (rev 259464)
+++ trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm 2020-04-03 16:43:13 UTC (rev 259465)
@@ -492,6 +492,7 @@
- (void)updateSupportedTypeIdentifiers:(NSArray<NSString *> *)types
{
+ NSLog(@"%s => %@", __PRETTY_FUNCTION__, types);
_supportedTypeIdentifiers = types;
}
Modified: trunk/Source/WebKit/ChangeLog (259464 => 259465)
--- trunk/Source/WebKit/ChangeLog 2020-04-03 16:26:51 UTC (rev 259464)
+++ trunk/Source/WebKit/ChangeLog 2020-04-03 16:43:13 UTC (rev 259465)
@@ -1,3 +1,15 @@
+2020-04-03 Wenson Hsieh <[email protected]>
+
+ Add logging to help diagnose <webkit.org/b/209685>
+ https://bugs.webkit.org/show_bug.cgi?id=209967
+
+ Reviewed by Darin Adler.
+
+ See WebCore/ChangeLog.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView dropInteraction:sessionDidUpdate:]):
+
2020-04-03 youenn fablet <[email protected]>
ServiceWorkerFetchTask::timeoutTimerFired should not call contextClosed
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (259464 => 259465)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-04-03 16:26:51 UTC (rev 259464)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-04-03 16:43:13 UTC (rev 259465)
@@ -7829,6 +7829,7 @@
if ([delegate respondsToSelector:@selector(_webView:willUpdateDropProposalToProposal:forSession:)])
proposal = [delegate _webView:self.webView willUpdateDropProposalToProposal:proposal.get() forSession:session];
+ NSLog(@"%s => %lu", __PRETTY_FUNCTION__, [proposal operation]);
return proposal.autorelease();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
