Title: [259476] trunk/Source/WebKit
- Revision
- 259476
- Author
- [email protected]
- Date
- 2020-04-03 11:06:53 -0700 (Fri, 03 Apr 2020)
Log Message
Color Form Control does not come up on second selection in macCatalyst
https://bugs.webkit.org/show_bug.cgi?id=209939
<rdar://problem/61131345>
Reviewed by Wenson Hsieh.
On selection and manual dismissal of the form, we need to also call accessoryDone,
as the UIKit callbacks are not called on manual dismissal.
* UIProcess/ios/forms/WKFormColorPicker.mm:
(-[WKColorPicker colorMatrixView:didTapColorButton:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (259475 => 259476)
--- trunk/Source/WebKit/ChangeLog 2020-04-03 18:00:32 UTC (rev 259475)
+++ trunk/Source/WebKit/ChangeLog 2020-04-03 18:06:53 UTC (rev 259476)
@@ -1,3 +1,17 @@
+2020-04-03 Megan Gardner <[email protected]>
+
+ Color Form Control does not come up on second selection in macCatalyst
+ https://bugs.webkit.org/show_bug.cgi?id=209939
+ <rdar://problem/61131345>
+
+ Reviewed by Wenson Hsieh.
+
+ On selection and manual dismissal of the form, we need to also call accessoryDone,
+ as the UIKit callbacks are not called on manual dismissal.
+
+ * UIProcess/ios/forms/WKFormColorPicker.mm:
+ (-[WKColorPicker colorMatrixView:didTapColorButton:]):
+
2020-04-03 Brent Fulgham <[email protected]>
[macOS] Update sandbox rules for correct sanitizer paths in current OS releases
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm (259475 => 259476)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm 2020-04-03 18:00:32 UTC (rev 259475)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm 2020-04-03 18:06:53 UTC (rev 259476)
@@ -306,6 +306,7 @@
[self setControlValueFromUIColor:colorButton.color];
#if PLATFORM(MACCATALYST)
[_popover dismissPopoverAnimated:NO];
+ [_view accessoryDone];
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
