Title: [259533] trunk/Source/WebCore
- Revision
- 259533
- Author
- mmaxfi...@apple.com
- Date
- 2020-04-04 11:38:24 -0700 (Sat, 04 Apr 2020)
Log Message
Ahom text is busted
https://bugs.webkit.org/show_bug.cgi?id=209898
<rdar://problem/60571257>
Reviewed by Tim Horton.
https://en.wikipedia.org/wiki/Ahom_language
The Ahom language, U+11700 - U+1173F, requires the complex text codepath.
This patch also makes some languages adjacent in codepoint-space (Dogra,
Dives Akuru, Nandinagari, Zanabazar Square, Soyombo, Warang Citi, and
Pau Cin Hau) use the complex path too.
At some point, we really need to make the fast text codepath opt-in instead
of opt-out. This patch is a simple band-aid fix until we can do that.
No new tests because I can't find an appropriately licenced font.
There is Noto Serif Ahom, but that's licenced under SIL OFL, and I'm
not sure if that's an acceptable license to be committed to WebKit.
https://github.com/googlefonts/noto-fonts/tree/master/hinted/NotoSerifAhom
* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::characterRangeCodePath):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (259532 => 259533)
--- trunk/Source/WebCore/ChangeLog 2020-04-04 18:16:25 UTC (rev 259532)
+++ trunk/Source/WebCore/ChangeLog 2020-04-04 18:38:24 UTC (rev 259533)
@@ -1,3 +1,29 @@
+2020-04-04 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ Ahom text is busted
+ https://bugs.webkit.org/show_bug.cgi?id=209898
+ <rdar://problem/60571257>
+
+ Reviewed by Tim Horton.
+
+ https://en.wikipedia.org/wiki/Ahom_language
+
+ The Ahom language, U+11700 - U+1173F, requires the complex text codepath.
+ This patch also makes some languages adjacent in codepoint-space (Dogra,
+ Dives Akuru, Nandinagari, Zanabazar Square, Soyombo, Warang Citi, and
+ Pau Cin Hau) use the complex path too.
+
+ At some point, we really need to make the fast text codepath opt-in instead
+ of opt-out. This patch is a simple band-aid fix until we can do that.
+
+ No new tests because I can't find an appropriately licenced font.
+ There is Noto Serif Ahom, but that's licenced under SIL OFL, and I'm
+ not sure if that's an acceptable license to be committed to WebKit.
+ https://github.com/googlefonts/noto-fonts/tree/master/hinted/NotoSerifAhom
+
+ * platform/graphics/FontCascade.cpp:
+ (WebCore::FontCascade::characterRangeCodePath):
+
2020-04-04 Antti Koivisto <an...@apple.com>
Implement the css-color-4 behavior for inheritance of currentColor
Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (259532 => 259533)
--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2020-04-04 18:16:25 UTC (rev 259532)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2020-04-04 18:38:24 UTC (rev 259533)
@@ -822,8 +822,10 @@
continue;
if (supplementaryCharacter < 0x116D0) // Takri
return Complex;
- if (supplementaryCharacter < 0x11C00)
+ if (supplementaryCharacter < 0x11740)
continue;
+ if (supplementaryCharacter < 0x11C00) // Ahom, Dogra, Dives Akuru, Nandinagari, Zanabazar Square, Soyombo, Warang Citi, Pau Cin Hau
+ return Complex;
if (supplementaryCharacter < 0x11C70) // Bhaiksuki
return Complex;
if (supplementaryCharacter < 0x11CC0) // Marchen
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
