Title: [259591] trunk
Revision
259591
Author
commit-qu...@webkit.org
Date
2020-04-06 13:36:58 -0700 (Mon, 06 Apr 2020)

Log Message

Unreviewed, reverting r259469.
https://bugs.webkit.org/show_bug.cgi?id=210066

Introduced media playback regression (Requested by perarne on
#webkit).

Reverted changeset:

"[iOS] Deny mach lookup access to the runningboard service in
the WebContent process"
https://bugs.webkit.org/show_bug.cgi?id=209933
https://trac.webkit.org/changeset/259469

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (259590 => 259591)


--- trunk/LayoutTests/ChangeLog	2020-04-06 20:26:48 UTC (rev 259590)
+++ trunk/LayoutTests/ChangeLog	2020-04-06 20:36:58 UTC (rev 259591)
@@ -1,3 +1,18 @@
+2020-04-06  Commit Queue  <commit-qu...@webkit.org>
+
+        Unreviewed, reverting r259469.
+        https://bugs.webkit.org/show_bug.cgi?id=210066
+
+        Introduced media playback regression (Requested by perarne on
+        #webkit).
+
+        Reverted changeset:
+
+        "[iOS] Deny mach lookup access to the runningboard service in
+        the WebContent process"
+        https://bugs.webkit.org/show_bug.cgi?id=209933
+        https://trac.webkit.org/changeset/259469
+
 2020-04-06  Jacob Uphoff  <jacob_uph...@apple.com>
 
         [ macOS ] inspector/debugger/break-in-constructor-before-super.html is a flaky failure

Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt (259590 => 259591)


--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-04-06 20:26:48 UTC (rev 259590)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-04-06 20:36:58 UTC (rev 259591)
@@ -27,4 +27,3 @@
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.iconservices") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.lsd.mapdb") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.frontboard.systemappservices") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.runningboard") is false

Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html (259590 => 259591)


--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-04-06 20:26:48 UTC (rev 259590)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-04-06 20:36:58 UTC (rev 259591)
@@ -30,7 +30,6 @@
     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.iconservices\")");
     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.lsd.mapdb\")");
     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.frontboard.systemappservices\")");
-    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.runningboard\")");
 }
 </script>
 </head>

Modified: trunk/Source/WebKit/ChangeLog (259590 => 259591)


--- trunk/Source/WebKit/ChangeLog	2020-04-06 20:26:48 UTC (rev 259590)
+++ trunk/Source/WebKit/ChangeLog	2020-04-06 20:36:58 UTC (rev 259591)
@@ -1,3 +1,18 @@
+2020-04-06  Commit Queue  <commit-qu...@webkit.org>
+
+        Unreviewed, reverting r259469.
+        https://bugs.webkit.org/show_bug.cgi?id=210066
+
+        Introduced media playback regression (Requested by perarne on
+        #webkit).
+
+        Reverted changeset:
+
+        "[iOS] Deny mach lookup access to the runningboard service in
+        the WebContent process"
+        https://bugs.webkit.org/show_bug.cgi?id=209933
+        https://trac.webkit.org/changeset/259469
+
 2020-04-06  Per Arne Vollan  <pvol...@apple.com>
 
         Unreviewed sandbox compile fix.

Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (259590 => 259591)


--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-04-06 20:26:48 UTC (rev 259590)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-04-06 20:36:58 UTC (rev 259591)
@@ -554,8 +554,8 @@
     (deny ipc-posix-sem-create ipc-posix-sem-post ipc-posix-sem-unlink ipc-posix-sem-wait)
     (allow ipc-posix-sem-open))
 
-(deny mach-lookup (with telemetry-backtrace)
-    (global-name "com.apple.runningboard")
+(allow mach-lookup (with telemetry)
+    (global-name "com.apple.runningboard") ;; Needed by process assertion code (ProcessTaskStateObserver).
 )
 
 (allow system-sched
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to