Title: [259719] trunk/Tools
- Revision
- 259719
- Author
- aakash_j...@apple.com
- Date
- 2020-04-08 09:17:55 -0700 (Wed, 08 Apr 2020)
Log Message
[ews] Improve summary for CheckPatchRelevance build step (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=210146
Unreviewed follow-up fix.
Revert the failure message for CheckPatchRelevance to old one since it needs to match with status-bubble code.
* BuildSlaveSupport/ews-build/steps.py:
* BuildSlaveSupport/ews-build/steps_unittest.py:
(TestCheckPatchRelevance.test_non_relevant_patch):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (259718 => 259719)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-04-08 15:41:59 UTC (rev 259718)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-04-08 16:17:55 UTC (rev 259719)
@@ -346,15 +346,15 @@
self.finished(SUCCESS)
return None
- self._addToLog('stdio', 'This patch does not contain relevant changes.')
+ self._addToLog('stdio', 'This patch does not have relevant changes.')
self.finished(FAILURE)
self.build.results = SKIPPED
- self.build.buildFinished(['Patch {} doesn\'t contain relevant changes'.format(self.getProperty('patch_id', ''))], SKIPPED)
+ self.build.buildFinished(['Patch {} doesn\'t have relevant changes'.format(self.getProperty('patch_id', ''))], SKIPPED)
return None
def getResultSummary(self):
if self.results == FAILURE:
- return {u'step': u'Patch doesn\'t contain relevant changes'}
+ return {u'step': u'Patch doesn\'t have relevant changes'}
return super(CheckPatchRelevance, self).getResultSummary()
class BugzillaMixin(object):
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (259718 => 259719)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-04-08 15:41:59 UTC (rev 259718)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-04-08 16:17:55 UTC (rev 259719)
@@ -2192,7 +2192,7 @@
self.setupStep(CheckPatchRelevance())
self.setProperty('buildername', 'JSC-Tests-EWS')
self.setProperty('patch_id', '1234')
- self.expectOutcome(result=FAILURE, state_string='Patch doesn\'t contain relevant changes')
+ self.expectOutcome(result=FAILURE, state_string='Patch doesn\'t have relevant changes')
return self.runStep()
Modified: trunk/Tools/ChangeLog (259718 => 259719)
--- trunk/Tools/ChangeLog 2020-04-08 15:41:59 UTC (rev 259718)
+++ trunk/Tools/ChangeLog 2020-04-08 16:17:55 UTC (rev 259719)
@@ -1,5 +1,17 @@
2020-04-08 Aakash Jain <aakash_j...@apple.com>
+ [ews] Improve summary for CheckPatchRelevance build step (follow-up fix)
+ https://bugs.webkit.org/show_bug.cgi?id=210146
+
+ Unreviewed follow-up fix.
+
+ Revert the failure message for CheckPatchRelevance to old one since it needs to match with status-bubble code.
+ * BuildSlaveSupport/ews-build/steps.py:
+ * BuildSlaveSupport/ews-build/steps_unittest.py:
+ (TestCheckPatchRelevance.test_non_relevant_patch):
+
+2020-04-08 Aakash Jain <aakash_j...@apple.com>
+
EWS should skip mac-wk1 and mac-debug-wk1 tests for patches that only change WebKit2 sources
https://bugs.webkit.org/show_bug.cgi?id=210115
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
