Title: [259980] trunk/Source/WTF
- Revision
- 259980
- Author
- [email protected]
- Date
- 2020-04-12 09:05:26 -0700 (Sun, 12 Apr 2020)
Log Message
Follow-up: WTF::Persistence::Coder and WTF::Persistence::Decoder should use WARN_UNUSED_RETURN
<https://webkit.org/b/210238>
<rdar://problem/61491575>
Changes based on feedback from Alex Christensen and Darin Adler:
- Remove WARN_UNUSED_RETURN from methods returning Optional<>.
- Place WARN_UNUSED_RETURN consistently before the return type.
* wtf/persistence/PersistentDecoder.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (259979 => 259980)
--- trunk/Source/WTF/ChangeLog 2020-04-12 16:04:48 UTC (rev 259979)
+++ trunk/Source/WTF/ChangeLog 2020-04-12 16:05:26 UTC (rev 259980)
@@ -1,3 +1,15 @@
+2020-04-12 David Kilzer <[email protected]>
+
+ Follow-up: WTF::Persistence::Coder and WTF::Persistence::Decoder should use WARN_UNUSED_RETURN
+ <https://webkit.org/b/210238>
+ <rdar://problem/61491575>
+
+ Changes based on feedback from Alex Christensen and Darin Adler:
+ - Remove WARN_UNUSED_RETURN from methods returning Optional<>.
+ - Place WARN_UNUSED_RETURN consistently before the return type.
+
+ * wtf/persistence/PersistentDecoder.h:
+
2020-04-10 Alex Christensen <[email protected]>
PersistentCoders should use modern decoding syntax
Modified: trunk/Source/WTF/wtf/persistence/PersistentDecoder.h (259979 => 259980)
--- trunk/Source/WTF/wtf/persistence/PersistentDecoder.h 2020-04-12 16:04:48 UTC (rev 259979)
+++ trunk/Source/WTF/wtf/persistence/PersistentDecoder.h 2020-04-12 16:05:26 UTC (rev 259980)
@@ -41,9 +41,9 @@
size_t length() const { return m_bufferEnd - m_buffer; }
size_t currentOffset() const { return m_bufferPosition - m_buffer; }
- WTF_EXPORT_PRIVATE bool verifyChecksum() WARN_UNUSED_RETURN;
+ WTF_EXPORT_PRIVATE WARN_UNUSED_RETURN bool verifyChecksum();
- WTF_EXPORT_PRIVATE bool decodeFixedLengthData(uint8_t*, size_t) WARN_UNUSED_RETURN;
+ WTF_EXPORT_PRIVATE WARN_UNUSED_RETURN bool decodeFixedLengthData(uint8_t*, size_t);
WTF_EXPORT_PRIVATE Decoder& operator>>(Optional<bool>&);
WTF_EXPORT_PRIVATE Decoder& operator>>(Optional<uint8_t>&);
@@ -91,8 +91,8 @@
static constexpr bool isIPCDecoder = false;
private:
- WTF_EXPORT_PRIVATE bool bufferIsLargeEnoughToContain(size_t) const WARN_UNUSED_RETURN;
- template<typename Type> Decoder& decodeNumber(Optional<Type>&) WARN_UNUSED_RETURN;
+ WTF_EXPORT_PRIVATE WARN_UNUSED_RETURN bool bufferIsLargeEnoughToContain(size_t) const;
+ template<typename Type> Decoder& decodeNumber(Optional<Type>&);
const uint8_t* m_buffer;
const uint8_t* m_bufferPosition;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
