Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (259989 => 259990)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-12 19:51:40 UTC (rev 259990)
@@ -1,3 +1,13 @@
+2020-04-12 Darin Adler <[email protected]>
+
+ Fix a few mispellings of descendant and propagation
+ https://bugs.webkit.org/show_bug.cgi?id=210409
+
+ Reviewed by Mark Lam.
+
+ * ftl/FTLAbstractHeap.h: "descendants"
+ * offlineasm/ast.rb: "descendants"
+
2020-04-12 Ross Kirsling <[email protected]>
[ECMA-402] WebKit Intl does not allow calendar and numberingSystem options
Modified: trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.h (259989 => 259990)
--- trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.h 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.h 2020-04-12 19:51:40 UTC (rev 259990)
@@ -102,7 +102,7 @@
// Print information about this heap and its ancestors. This is the default.
void dump(PrintStream&) const;
- // Print information about this heap and its descendents. This is a multi-line dump.
+ // Print information about this heap and its descendants. This is a multi-line dump.
void deepDump(PrintStream&, unsigned indent = 0) const;
private:
Modified: trunk/Source/_javascript_Core/offlineasm/ast.rb (259989 => 259990)
--- trunk/Source/_javascript_Core/offlineasm/ast.rb 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/_javascript_Core/offlineasm/ast.rb 2020-04-12 19:51:40 UTC (rev 259990)
@@ -31,7 +31,7 @@
#
# node.children -> Returns an array of immediate children.
#
-# node.descendents -> Returns an array of all strict descendants (children
+# node.descendants -> Returns an array of all strict descendants (children
# and children of children, transitively).
#
# node.flatten -> Returns an array containing the strict descendants and
Modified: trunk/Source/WebCore/ChangeLog (259989 => 259990)
--- trunk/Source/WebCore/ChangeLog 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/WebCore/ChangeLog 2020-04-12 19:51:40 UTC (rev 259990)
@@ -1,5 +1,25 @@
2020-04-12 Darin Adler <[email protected]>
+ Fix a few mispellings of descendant and propagation
+ https://bugs.webkit.org/show_bug.cgi?id=210409
+
+ Reviewed by Mark Lam.
+
+ * dom/Element.cpp:
+ (WebCore::Element::dispatchWheelEvent): "propagation"
+ * dom/TreeScopeOrderedMap.cpp:
+ (WebCore::TreeScopeOrderedMap::getAllElementsById const):
+ "descendants". Also refactored this function a bit.
+ * html/MediaElementSession.cpp:
+ (WebCore::MediaElementSession::canShowControlsManager const):
+ "descendants"
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::resetFrameRendererAndDescendants): "descendants"
+ (WebCore::RenderFrameSet::positionFrames): "descendants"
+ (WebCore::RenderFrameSet::positionFramesWithFlattening): "descendants"
+
+2020-04-12 Darin Adler <[email protected]>
+
Refactor and tighten up the CSSVariableReferenceValue class
https://bugs.webkit.org/show_bug.cgi?id=210406
Modified: trunk/Source/WebCore/dom/Element.cpp (259989 => 259990)
--- trunk/Source/WebCore/dom/Element.cpp 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/WebCore/dom/Element.cpp 2020-04-12 19:51:40 UTC (rev 259990)
@@ -396,7 +396,7 @@
// Events with no deltas are important because they convey platform information about scroll gestures
// and momentum beginning or ending. However, those events should not be sent to the DOM since some
// websites will break. They need to be dispatched because dispatching them will call into the default
- // event handler, and our platform code will correctly handle the phase changes. Calling stopPropogation()
+ // event handler, and our platform code will correctly handle the phase changes. Calling stopPropagation()
// will prevent the event from being sent to the DOM, but will still call the default event handler.
// FIXME: Move this logic into WheelEvent::create.
if (!platformEvent.deltaX() && !platformEvent.deltaY())
Modified: trunk/Source/WebCore/dom/TreeScopeOrderedMap.cpp (259989 => 259990)
--- trunk/Source/WebCore/dom/TreeScopeOrderedMap.cpp 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/WebCore/dom/TreeScopeOrderedMap.cpp 2020-04-12 19:51:40 UTC (rev 259990)
@@ -196,23 +196,19 @@
{
m_map.checkConsistency();
- auto it = m_map.find(&key);
- if (it == m_map.end())
+ auto mapIterator = m_map.find(&key);
+ if (mapIterator == m_map.end())
return nullptr;
- MapEntry& entry = it->value;
+ auto& entry = mapIterator->value;
RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(entry.count);
if (entry.orderedList.isEmpty()) {
entry.orderedList.reserveCapacity(entry.count);
- auto elementDescandents = descendantsOfType<Element>(scope.rootNode());
- auto it = entry.element ? elementDescandents.beginAt(*entry.element) : elementDescandents.begin();
- auto end = elementDescandents.end();
- for (; it != end; ++it) {
- auto& element = *it;
- if (element.getIdAttribute().impl() != &key)
- continue;
- entry.orderedList.append(&element);
+ auto elementDescendants = descendantsOfType<Element>(scope.rootNode());
+ for (auto it = entry.element ? elementDescendants.beginAt(*entry.element) : elementDescendants.begin(); it; ++it) {
+ if (it->getIdAttribute().impl() == &key)
+ entry.orderedList.append(&*it);
}
RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(entry.orderedList.size() == entry.count);
}
Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (259989 => 259990)
--- trunk/Source/WebCore/html/MediaElementSession.cpp 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp 2020-04-12 19:51:40 UTC (rev 259990)
@@ -483,7 +483,7 @@
}
#if ENABLE(FULLSCREEN_API)
- // Elements which are not descendents of the current fullscreen element cannot be main content.
+ // Elements which are not descendants of the current fullscreen element cannot be main content.
auto* fullscreenElement = m_element.document().fullscreenManager().currentFullscreenElement();
if (fullscreenElement && !m_element.isDescendantOf(*fullscreenElement)) {
INFO_LOG(LOGIDENTIFIER, "returning FALSE: outside of full screen");
Modified: trunk/Source/WebCore/rendering/RenderFrameSet.cpp (259989 => 259990)
--- trunk/Source/WebCore/rendering/RenderFrameSet.cpp 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/WebCore/rendering/RenderFrameSet.cpp 2020-04-12 19:51:40 UTC (rev 259990)
@@ -494,7 +494,7 @@
clearNeedsLayout();
}
-static void resetFrameRendererAndDescendents(RenderBox* frameSetChild, RenderFrameSet& parentFrameSet)
+static void resetFrameRendererAndDescendants(RenderBox* frameSetChild, RenderFrameSet& parentFrameSet)
{
if (!frameSetChild)
return;
@@ -544,7 +544,7 @@
yPos += height + borderThickness;
}
- resetFrameRendererAndDescendents(child, *this);
+ resetFrameRendererAndDescendants(child, *this);
}
void RenderFrameSet::positionFramesWithFlattening()
@@ -647,7 +647,7 @@
if (repaintNeeded)
repaint();
- resetFrameRendererAndDescendents(child, *this);
+ resetFrameRendererAndDescendants(child, *this);
}
bool RenderFrameSet::flattenFrameSet() const
Modified: trunk/Source/WebInspectorUI/ChangeLog (259989 => 259990)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-04-12 19:51:40 UTC (rev 259990)
@@ -1,3 +1,15 @@
+2020-04-12 Darin Adler <[email protected]>
+
+ Fix a few mispellings of descendant and propagation
+ https://bugs.webkit.org/show_bug.cgi?id=210409
+
+ Reviewed by Mark Lam.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype._rememberTreeElement):
+ (WI.TreeOutline.prototype._forgetTreeElement):
+ (WI.TreeOutline.prototype.selectionControllerNumberOfItems):
+
2020-04-11 Devin Rousso <[email protected]>
Web Inspector: CSS: variables should have a go-to arrow to quickly jump to the definition
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (259989 => 259990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2020-04-12 19:34:59 UTC (rev 259989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2020-04-12 19:51:40 UTC (rev 259990)
@@ -55,7 +55,7 @@
this._customIndent = false;
this._selectable = selectable;
- this._cachedNumberOfDescendents = 0;
+ this._cachedNumberOfDescendants = 0;
let comparator = (a, b) => {
function getLevel(treeElement) {
@@ -445,7 +445,7 @@
var elements = this._knownTreeElements[element.identifier];
if (!elements.includes(element)) {
elements.push(element);
- this._cachedNumberOfDescendents++;
+ this._cachedNumberOfDescendants++;
}
if (this.virtualized)
@@ -461,7 +461,7 @@
if (this._knownTreeElements[element.identifier]) {
if (this._knownTreeElements[element.identifier].remove(element))
- this._cachedNumberOfDescendents--;
+ this._cachedNumberOfDescendants--;
}
if (this.virtualized)
@@ -772,7 +772,7 @@
selectionControllerNumberOfItems(controller)
{
- return this._cachedNumberOfDescendents;
+ return this._cachedNumberOfDescendants;
}
selectionControllerSelectionDidChange(controller, deselectedItems, selectedItems)
