Title: [259998] trunk/Source/WebCore
- Revision
- 259998
- Author
- [email protected]
- Date
- 2020-04-13 01:24:39 -0700 (Mon, 13 Apr 2020)
Log Message
Remove return parameter from FrameLoader::closeURL
https://bugs.webkit.org/show_bug.cgi?id=210404
Patch by Rob Buis <[email protected]> on 2020-04-13
Reviewed by Manuel Rego Casasnovas.
Remove return parameter from FrameLoader::closeURL since it always
returns true and is never tested.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::closeURL):
* loader/FrameLoader.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (259997 => 259998)
--- trunk/Source/WebCore/ChangeLog 2020-04-13 08:04:39 UTC (rev 259997)
+++ trunk/Source/WebCore/ChangeLog 2020-04-13 08:24:39 UTC (rev 259998)
@@ -1,5 +1,19 @@
2020-04-13 Rob Buis <[email protected]>
+ Remove return parameter from FrameLoader::closeURL
+ https://bugs.webkit.org/show_bug.cgi?id=210404
+
+ Reviewed by Manuel Rego Casasnovas.
+
+ Remove return parameter from FrameLoader::closeURL since it always
+ returns true and is never tested.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::closeURL):
+ * loader/FrameLoader.h:
+
+2020-04-13 Rob Buis <[email protected]>
+
Remove addExtraFieldsToSubresourceRequest
https://bugs.webkit.org/show_bug.cgi?id=210407
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (259997 => 259998)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2020-04-13 08:04:39 UTC (rev 259997)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2020-04-13 08:24:39 UTC (rev 259998)
@@ -552,7 +552,7 @@
}
}
-bool FrameLoader::closeURL()
+void FrameLoader::closeURL()
{
history().saveDocumentState();
@@ -569,7 +569,6 @@
stopLoading(unloadEventPolicy);
m_frame.editor().clearUndoRedoOperations();
- return true;
}
bool FrameLoader::didOpenURL()
Modified: trunk/Source/WebCore/loader/FrameLoader.h (259997 => 259998)
--- trunk/Source/WebCore/loader/FrameLoader.h 2020-04-13 08:04:39 UTC (rev 259997)
+++ trunk/Source/WebCore/loader/FrameLoader.h 2020-04-13 08:24:39 UTC (rev 259998)
@@ -155,7 +155,7 @@
void stopForBackForwardCache();
void stop();
void stopLoading(UnloadEventPolicy);
- bool closeURL();
+ void closeURL();
void cancelAndClear();
void clearProvisionalLoadForPolicyCheck();
// FIXME: clear() is trying to do too many things. We should break it down into smaller functions (ideally with fewer raw Boolean parameters).
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
