Title: [260077] trunk/Source/WebKit
- Revision
- 260077
- Author
- megan_gard...@apple.com
- Date
- 2020-04-14 09:38:50 -0700 (Tue, 14 Apr 2020)
Log Message
YouTube sometimes navigates unexpectedly when invoking a context menu on a video link.
https://bugs.webkit.org/show_bug.cgi?id=210467
<rdar://problem/58841584>
Reviewed by Tim Horton.
Cancel any outstanding touches tracked by WebTouchEventsGestureRecognizer, so that we dispatch
`touchcancel` to the page instead of `touchend`, so that the page does not misinterpret
context menu invocation as a tap.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260076 => 260077)
--- trunk/Source/WebKit/ChangeLog 2020-04-14 16:19:47 UTC (rev 260076)
+++ trunk/Source/WebKit/ChangeLog 2020-04-14 16:38:50 UTC (rev 260077)
@@ -1,3 +1,18 @@
+2020-04-14 Megan Gardner <megan_gard...@apple.com>
+
+ YouTube sometimes navigates unexpectedly when invoking a context menu on a video link.
+ https://bugs.webkit.org/show_bug.cgi?id=210467
+ <rdar://problem/58841584>
+
+ Reviewed by Tim Horton.
+
+ Cancel any outstanding touches tracked by WebTouchEventsGestureRecognizer, so that we dispatch
+ `touchcancel` to the page instead of `touchend`, so that the page does not misinterpret
+ context menu invocation as a tap.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
+
2020-04-14 Youenn Fablet <you...@apple.com>
Do not process RTC Network messages coming from NetworkProcess if LibWebRTCNetwork is not active
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (260076 => 260077)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-04-14 16:19:47 UTC (rev 260076)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-04-14 16:38:50 UTC (rev 260077)
@@ -9095,6 +9095,7 @@
- (UITargetedPreview *)contextMenuInteraction:(UIContextMenuInteraction *)interaction previewForHighlightingMenuWithConfiguration:(UIContextMenuConfiguration *)configuration
{
[self _startSuppressingSelectionAssistantForReason:WebKit::InteractionIsHappening];
+ [self _cancelTouchEventGestureRecognizer];
return [self _createTargetedContextMenuHintPreviewIfPossible];
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
