Title: [260142] trunk/Source/WebCore
- Revision
- 260142
- Author
- [email protected]
- Date
- 2020-04-15 11:53:02 -0700 (Wed, 15 Apr 2020)
Log Message
REGRESSION (r258977): Crash under Document::visibilityStateChanged
https://bugs.webkit.org/show_bug.cgi?id=210555
Reviewed by Youenn Fablet.
Re-introduce null check of page in Document::visibilityStateChanged() which got inadvertently
dropped in r258977.
* dom/Document.cpp:
(WebCore::Document::visibilityStateChanged):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (260141 => 260142)
--- trunk/Source/WebCore/ChangeLog 2020-04-15 18:32:17 UTC (rev 260141)
+++ trunk/Source/WebCore/ChangeLog 2020-04-15 18:53:02 UTC (rev 260142)
@@ -1,3 +1,16 @@
+2020-04-15 Chris Dumez <[email protected]>
+
+ REGRESSION (r258977): Crash under Document::visibilityStateChanged
+ https://bugs.webkit.org/show_bug.cgi?id=210555
+
+ Reviewed by Youenn Fablet.
+
+ Re-introduce null check of page in Document::visibilityStateChanged() which got inadvertently
+ dropped in r258977.
+
+ * dom/Document.cpp:
+ (WebCore::Document::visibilityStateChanged):
+
2020-04-15 Zalan Bujtas <[email protected]>
REGRESSION( r260114): [ Mac and iOS ] imported/w3c/web-platform-tests/web-animations/timing-model/timelines/document-timelines.html is failing.
Modified: trunk/Source/WebCore/dom/Document.cpp (260141 => 260142)
--- trunk/Source/WebCore/dom/Document.cpp 2020-04-15 18:32:17 UTC (rev 260141)
+++ trunk/Source/WebCore/dom/Document.cpp 2020-04-15 18:53:02 UTC (rev 260142)
@@ -1745,8 +1745,9 @@
client->visibilityStateChanged();
#if ENABLE(MEDIA_STREAM)
- if (hidden()) {
- RealtimeMediaSourceCenter::singleton().setCapturePageState(hidden(), page()->isMediaCaptureMuted());
+ auto* page = this->page();
+ if (page && hidden()) {
+ RealtimeMediaSourceCenter::singleton().setCapturePageState(true, page->isMediaCaptureMuted());
return;
}
#if PLATFORM(IOS_FAMILY)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
