Title: [260189] trunk/LayoutTests
- Revision
- 260189
- Author
- grao...@webkit.org
- Date
- 2020-04-16 08:52:58 -0700 (Thu, 16 Apr 2020)
Log Message
[ Mac wk2 Debug ] media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=210349
<rdar://problem/61594098>
Reviewed by Eric Carlson.
This test had several things wrong about it. First, it manually created a MediaController in the test page and set a custom auto-hide delay on it.
However, it would test the proper behavior of the auto-hide behavior on the MediaController created by the media element, querying the state of
the media controls markup within that media element's shadow root. In that world, the auto-hide delay was the default delay, and not the custom
one set on the page-created MediaController.
The cause of the timeout was that the media clip used in this test is barely longer than the auto-hide delay, and it could happen that under slow
conditions, the media would end and the auto-hide timer would never have a chance to fire since it would be canceled due to auto-hide being disabled
when the media is not playing, such as when it ended.
We make this test saner and more realistic by not customizing the auto-hide delay, removing the page MediaController and simply setting "loop" on the
media element such that it never stops playing, givin the auto-hide timer additional time to fire with no risk of it being canceled by the media ending.
* media/modern-media-controls/media-controller/media-controller-auto-hide.html:
* platform/mac-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (260188 => 260189)
--- trunk/LayoutTests/ChangeLog 2020-04-16 15:45:04 UTC (rev 260188)
+++ trunk/LayoutTests/ChangeLog 2020-04-16 15:52:58 UTC (rev 260189)
@@ -1,3 +1,26 @@
+2020-04-16 Antoine Quint <grao...@apple.com>
+
+ [ Mac wk2 Debug ] media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out.
+ https://bugs.webkit.org/show_bug.cgi?id=210349
+ <rdar://problem/61594098>
+
+ Reviewed by Eric Carlson.
+
+ This test had several things wrong about it. First, it manually created a MediaController in the test page and set a custom auto-hide delay on it.
+ However, it would test the proper behavior of the auto-hide behavior on the MediaController created by the media element, querying the state of
+ the media controls markup within that media element's shadow root. In that world, the auto-hide delay was the default delay, and not the custom
+ one set on the page-created MediaController.
+
+ The cause of the timeout was that the media clip used in this test is barely longer than the auto-hide delay, and it could happen that under slow
+ conditions, the media would end and the auto-hide timer would never have a chance to fire since it would be canceled due to auto-hide being disabled
+ when the media is not playing, such as when it ended.
+
+ We make this test saner and more realistic by not customizing the auto-hide delay, removing the page MediaController and simply setting "loop" on the
+ media element such that it never stops playing, givin the auto-hide timer additional time to fire with no risk of it being canceled by the media ending.
+
+ * media/modern-media-controls/media-controller/media-controller-auto-hide.html:
+ * platform/mac-wk2/TestExpectations:
+
2020-04-16 Diego Pino Garcia <dp...@igalia.com>
[GTK] Gardening, mark several animations test as failure
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html (260188 => 260189)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html 2020-04-16 15:45:04 UTC (rev 260188)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html 2020-04-16 15:52:58 UTC (rev 260189)
@@ -1,11 +1,8 @@
<!DOCTYPE html>
<script src=""
-<script src="" type="text/_javascript_"></script>
-<script src="" type="text/_javascript_"></script>
<script src=""
<body>
- <video style="position: absolute; left: 0; top: 0; width: 320px; height: 240px;" controls autoplay></video>
- <div id="host"></div>
+ <video style="position: absolute; left: 0; top: 0; width: 320px; height: 240px;" controls autoplay loop></video>
<script type="text/_javascript_">
window.jsTestIsAsync = true;
@@ -16,10 +13,6 @@
media.src = ""
const shadowRoot = window.internals.shadowRoot(media);
- const container = document.querySelector("div#host");
- const mediaController = createControls(container, media, null);
-
- mediaController.controls.autoHideController.autoHideDelay = 100;
media.addEventListener("play", (event) => {
shouldBecomeEqual("!!shadowRoot.querySelector('.media-controls')", "true", () => {
shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (260188 => 260189)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-04-16 15:45:04 UTC (rev 260188)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-04-16 15:52:58 UTC (rev 260189)
@@ -1044,6 +1044,4 @@
webkit.org/b/210165 [ Catalina ] webrtc/peer-connection-audio-mute2.html [ Pass Timeout Failure ]
-webkit.org/b/210349 [ Debug ] media/modern-media-controls/media-controller/media-controller-auto-hide.html [ Pass Timeout ]
-
webkit.org/b/210433 swipe/basic-cached-back-swipe.html [ Pass Crash Timeout ]
\ No newline at end of file
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
