Title: [260198] branches/safari-609-branch/Source/WTF
- Revision
- 260198
- Author
- [email protected]
- Date
- 2020-04-16 10:44:19 -0700 (Thu, 16 Apr 2020)
Log Message
Cherry-pick r259980. rdar://problem/61888315
Follow-up: WTF::Persistence::Coder and WTF::Persistence::Decoder should use WARN_UNUSED_RETURN
<https://webkit.org/b/210238>
<rdar://problem/61491575>
Changes based on feedback from Alex Christensen and Darin Adler:
- Remove WARN_UNUSED_RETURN from methods returning Optional<>.
- Place WARN_UNUSED_RETURN consistently before the return type.
* wtf/persistence/PersistentDecoder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609-branch/Source/WTF/ChangeLog (260197 => 260198)
--- branches/safari-609-branch/Source/WTF/ChangeLog 2020-04-16 17:44:15 UTC (rev 260197)
+++ branches/safari-609-branch/Source/WTF/ChangeLog 2020-04-16 17:44:19 UTC (rev 260198)
@@ -1,5 +1,33 @@
2020-04-16 Alan Coon <[email protected]>
+ Cherry-pick r259980. rdar://problem/61888315
+
+ Follow-up: WTF::Persistence::Coder and WTF::Persistence::Decoder should use WARN_UNUSED_RETURN
+ <https://webkit.org/b/210238>
+ <rdar://problem/61491575>
+
+ Changes based on feedback from Alex Christensen and Darin Adler:
+ - Remove WARN_UNUSED_RETURN from methods returning Optional<>.
+ - Place WARN_UNUSED_RETURN consistently before the return type.
+
+ * wtf/persistence/PersistentDecoder.h:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-04-12 David Kilzer <[email protected]>
+
+ Follow-up: WTF::Persistence::Coder and WTF::Persistence::Decoder should use WARN_UNUSED_RETURN
+ <https://webkit.org/b/210238>
+ <rdar://problem/61491575>
+
+ Changes based on feedback from Alex Christensen and Darin Adler:
+ - Remove WARN_UNUSED_RETURN from methods returning Optional<>.
+ - Place WARN_UNUSED_RETURN consistently before the return type.
+
+ * wtf/persistence/PersistentDecoder.h:
+
+2020-04-16 Alan Coon <[email protected]>
+
Cherry-pick r259814. rdar://problem/61888315
WTF::Persistence::Coder and WTF::Persistence::Decoder should use WARN_UNUSED_RETURN
Modified: branches/safari-609-branch/Source/WTF/wtf/persistence/PersistentDecoder.h (260197 => 260198)
--- branches/safari-609-branch/Source/WTF/wtf/persistence/PersistentDecoder.h 2020-04-16 17:44:15 UTC (rev 260197)
+++ branches/safari-609-branch/Source/WTF/wtf/persistence/PersistentDecoder.h 2020-04-16 17:44:19 UTC (rev 260198)
@@ -41,9 +41,9 @@
size_t length() const { return m_bufferEnd - m_buffer; }
size_t currentOffset() const { return m_bufferPosition - m_buffer; }
- WTF_EXPORT_PRIVATE bool verifyChecksum() WARN_UNUSED_RETURN;
+ WTF_EXPORT_PRIVATE WARN_UNUSED_RETURN bool verifyChecksum();
- WTF_EXPORT_PRIVATE bool decodeFixedLengthData(uint8_t*, size_t) WARN_UNUSED_RETURN;
+ WTF_EXPORT_PRIVATE WARN_UNUSED_RETURN bool decodeFixedLengthData(uint8_t*, size_t);
WTF_EXPORT_PRIVATE bool decode(bool&) WARN_UNUSED_RETURN;
WTF_EXPORT_PRIVATE bool decode(uint8_t&) WARN_UNUSED_RETURN;
@@ -102,8 +102,8 @@
static constexpr bool isIPCDecoder = false;
private:
- WTF_EXPORT_PRIVATE bool bufferIsLargeEnoughToContain(size_t) const WARN_UNUSED_RETURN;
- template<typename Type> bool decodeNumber(Type&) WARN_UNUSED_RETURN;
+ WTF_EXPORT_PRIVATE WARN_UNUSED_RETURN bool bufferIsLargeEnoughToContain(size_t) const;
+ template<typename Type> bool decodeNumber(Type&);
const uint8_t* m_buffer;
const uint8_t* m_bufferPosition;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
