Title: [260384] trunk
- Revision
- 260384
- Author
- [email protected]
- Date
- 2020-04-20 12:11:46 -0700 (Mon, 20 Apr 2020)
Log Message
[JSC] Skip test262 for non-safe-integer range BigIntConstructor
https://bugs.webkit.org/show_bug.cgi?id=210749
Reviewed by Keith Miller.
JSTests:
We skip test262 test/built-ins/BigInt/constructor-integer.js for now. As it is shown in old test262 JSTests/test262/expectations.yaml,
this test was failing before BigInt flag is enabled. And new BigInt patch changes error message while we are failing in the same way.
While we implemented BigInt, this test is based on spec change introduced[1], and we are not implementing this. So we mark it skipped,
as it is skipped before BigInt is enabled.
[1]: https://github.com/tc39/proposal-bigint/pull/138
* test262/config.yaml:
Source/_javascript_Core:
* runtime/BigIntConstructor.cpp:
(JSC::callBigIntConstructor):
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (260383 => 260384)
--- trunk/JSTests/ChangeLog 2020-04-20 19:10:00 UTC (rev 260383)
+++ trunk/JSTests/ChangeLog 2020-04-20 19:11:46 UTC (rev 260384)
@@ -1,3 +1,19 @@
+2020-04-20 Yusuke Suzuki <[email protected]>
+
+ [JSC] Skip test262 for non-safe-integer range BigIntConstructor
+ https://bugs.webkit.org/show_bug.cgi?id=210749
+
+ Reviewed by Keith Miller.
+
+ We skip test262 test/built-ins/BigInt/constructor-integer.js for now. As it is shown in old test262 JSTests/test262/expectations.yaml,
+ this test was failing before BigInt flag is enabled. And new BigInt patch changes error message while we are failing in the same way.
+ While we implemented BigInt, this test is based on spec change introduced[1], and we are not implementing this. So we mark it skipped,
+ as it is skipped before BigInt is enabled.
+
+ [1]: https://github.com/tc39/proposal-bigint/pull/138
+
+ * test262/config.yaml:
+
2020-04-20 Keith Miller <[email protected]>
Unreviewed, revert accidental test changes.
Modified: trunk/JSTests/test262/config.yaml (260383 => 260384)
--- trunk/JSTests/test262/config.yaml 2020-04-20 19:10:00 UTC (rev 260383)
+++ trunk/JSTests/test262/config.yaml 2020-04-20 19:11:46 UTC (rev 260384)
@@ -157,3 +157,6 @@
# requires ICU 65 (https://unicode-org.atlassian.net/browse/ICU-20654)
- test/intl402/RelativeTimeFormat/prototype/format/en-us-numeric-auto.js
- test/intl402/RelativeTimeFormat/prototype/formatToParts/en-us-numeric-auto.js
+
+ # Spec is changed. https://github.com/tc39/proposal-bigint/pull/138
+ - test/built-ins/BigInt/constructor-integer.js
Modified: trunk/Source/_javascript_Core/ChangeLog (260383 => 260384)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-20 19:10:00 UTC (rev 260383)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-20 19:11:46 UTC (rev 260384)
@@ -1,3 +1,13 @@
+2020-04-20 Yusuke Suzuki <[email protected]>
+
+ [JSC] Skip test262 for non-safe-integer range BigIntConstructor
+ https://bugs.webkit.org/show_bug.cgi?id=210749
+
+ Reviewed by Keith Miller.
+
+ * runtime/BigIntConstructor.cpp:
+ (JSC::callBigIntConstructor):
+
2020-04-20 Keith Miller <[email protected]>
Fix CheckIsConstant for non-constant values and checking for empty
Modified: trunk/Source/_javascript_Core/runtime/BigIntConstructor.cpp (260383 => 260384)
--- trunk/Source/_javascript_Core/runtime/BigIntConstructor.cpp 2020-04-20 19:10:00 UTC (rev 260383)
+++ trunk/Source/_javascript_Core/runtime/BigIntConstructor.cpp 2020-04-20 19:11:46 UTC (rev 260384)
@@ -120,6 +120,8 @@
}
if (primitive.isDouble()) {
+ // FIXME: Accept larger integers than safe-integers.
+ // https://bugs.webkit.org/show_bug.cgi?id=210755
double number = primitive.asDouble();
if (trunc(number) != number || std::abs(number) > maxSafeInteger())
return throwVMError(globalObject, scope, createRangeError(globalObject, "Not a safe integer"_s));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
